Skip to content

[dev] [claudfuen] claudio/fix-file-upload #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claudfuen merged 1 commit into from
Jul 31, 2025
Merged

[dev] [claudfuen] claudio/fix-file-upload #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 7 additions & 17 deletions apps/app/src/app/s3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,13 @@ if (!APP_AWS_ACCESS_KEY_ID || !APP_AWS_SECRET_ACCESS_KEY || !BUCKET_NAME || !APP
// Create a single S3 client instance
// Add null checks or assertions if the checks above don't guarantee non-null values

export const s3Client = new S3Client(
// If we are on Vercel, we MUST provide explicit credentials.
process.env.VERCEL === '1'
? {
region: APP_AWS_REGION!,
credentials: {
accessKeyId: APP_AWS_ACCESS_KEY_ID!,
secretAccessKey: APP_AWS_SECRET_ACCESS_KEY!,
},
}
: // For any other environment (like AWS ECS or local dev),
// we only need to provide the region. The AWS SDK will
// automatically find the credentials from the environment.
{
region: APP_AWS_REGION!,
},
);
export const s3Client = new S3Client({
region: APP_AWS_REGION!,
credentials: {
accessKeyId: APP_AWS_ACCESS_KEY_ID!,
secretAccessKey: APP_AWS_SECRET_ACCESS_KEY!,
},
});

// Ensure BUCKET_NAME is exported and non-null checked if needed elsewhere explicitly
if (!BUCKET_NAME && process.env.NODE_ENV === 'production') {
Expand Down
24 changes: 7 additions & 17 deletions apps/portal/src/utils/s3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,13 @@ if (!APP_AWS_ACCESS_KEY_ID || !APP_AWS_SECRET_ACCESS_KEY || !BUCKET_NAME || !APP

// Create a single S3 client instance
// Add null checks or assertions if the checks above don't guarantee non-null values
export const s3Client = new S3Client(
// If we are on Vercel, we MUST provide explicit credentials.
process.env.VERCEL === '1'
? {
region: APP_AWS_REGION!,
credentials: {
accessKeyId: APP_AWS_ACCESS_KEY_ID!,
secretAccessKey: APP_AWS_SECRET_ACCESS_KEY!,
},
}
: // For any other environment (like AWS ECS or local dev),
// we only need to provide the region. The AWS SDK will
// automatically find the credentials from the environment.
{
region: APP_AWS_REGION!,
},
);
export const s3Client = new S3Client({
region: APP_AWS_REGION!,
credentials: {
accessKeyId: APP_AWS_ACCESS_KEY_ID!,
secretAccessKey: APP_AWS_SECRET_ACCESS_KEY!,
},
});

// Ensure BUCKET_NAME is exported and non-null checked if needed elsewhere explicitly
if (!BUCKET_NAME && process.env.NODE_ENV === 'production') {
Expand Down