Skip to content

Conversation

@Marfuen
Copy link
Contributor

@Marfuen Marfuen commented Dec 15, 2025

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes COMP-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel
Copy link

vercel bot commented Dec 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Review Updated (UTC)
app Skipped Skipped Dec 15, 2025 4:24am
portal Skipped Skipped Dec 15, 2025 4:24am

@cursor
Copy link

cursor bot commented Dec 15, 2025

PR Summary

Adds safe cleanup for Stagehand and Browserbase sessions, ensuring close errors are logged and ignored so they never mask successful automation results.

  • Backend (Browserbase service):
    • Stagehand lifecycle:
      • Add safeCloseStagehand to log and ignore stagehand.close() errors.
      • Replace direct stagehand.close() with safeCloseStagehand in navigateToUrl, checkLoginStatus, and executeAutomation.
    • Session management:
      • Wrap closeSession(sessionId) in a try/catch during runBrowserAutomation cleanup and log warnings without failing the run.

Written by Cursor Bugbot for commit c98befe. This will update automatically on new commits. Configure here.

@vercel vercel bot temporarily deployed to Preview – portal December 15, 2025 04:24 Inactive
@vercel vercel bot temporarily deployed to Preview – app December 15, 2025 04:24 Inactive
@Marfuen Marfuen merged commit bcfc81a into main Dec 15, 2025
9 of 11 checks passed
@Marfuen Marfuen deleted the mariano/agent-4 branch December 15, 2025 04:24
@graphite-app
Copy link

graphite-app bot commented Dec 15, 2025

Graphite Automations

"Auto-assign PRs to Author" took an action on this PR • (12/15/25)

1 assignee was added to this PR based on Mariano Fuentes's automation.

@claudfuen
Copy link
Contributor

🎉 This PR is included in version 1.71.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants