Skip to content

[dev] [tofikwest] tofik/aws-integration-fix#2071

Merged
tofikwest merged 4 commits intomainfrom
tofik/aws-integration-fix
Jan 29, 2026
Merged

[dev] [tofikwest] tofik/aws-integration-fix#2071
tofikwest merged 4 commits intomainfrom
tofik/aws-integration-fix

Conversation

@github-actions
Copy link
Contributor

This is an automated pull request to merge tofik/aws-integration-fix into dev.
It was created by the [Auto Pull Request] action.

@vercel
Copy link

vercel bot commented Jan 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Review Updated (UTC)
app Skipped Skipped Jan 29, 2026 4:33am
portal Skipped Skipped Jan 29, 2026 4:33am

Request Review

@cursor
Copy link

cursor bot commented Jan 29, 2026

PR Summary

Medium Risk
Medium risk because it changes cloud security scan orchestration and AWS Security Hub collection behavior (multi-region iteration, role assumption reuse, partial-failure handling), which can affect scan coverage and operational load.

Overview
Cloud security scans now run on a dedicated daily schedule for multi-connection providers. A new Trigger.dev orchestrator (cloud-security-schedule) finds active integrationConnections whose manifests set supportsMultipleConnections and batch-triggers per-connection scan workers (run-cloud-security-scan) that call the /v1/cloud-security/scan/:connectionId endpoint.

AWS Security Hub scanning is updated for multi-region collection and improved failure handling. AWSSecurityService.scanSecurityFindings now derives a region list (from credentials.regions/variables.regions or fallback), assumes role once, scans each region with shared creds, tolerates per-region failures (warn + continue), and errors only if all regions fail; findings are tagged with region and titles include the region for filtering.

Frontend/compat tweaks for mixed legacy + new connections. The cloud tests findings API no longer excludes legacy providers when a new-platform connection exists for the same slug, the UI prevents adding connections while provider data is revalidating, hides multi-connection providers from CloudSettingsModal, and ConnectIntegrationDialog now shows a loading spinner while provider/connection data is fetching to avoid incorrect initial view selection.

Written by Cursor Bugbot for commit 69199f8. This will update automatically on new commits. Configure here.

@vercel vercel bot temporarily deployed to Preview – app January 29, 2026 03:58 Inactive
@vercel vercel bot temporarily deployed to Preview – portal January 29, 2026 03:58 Inactive
@vercel vercel bot temporarily deployed to Preview – portal January 29, 2026 04:18 Inactive
@vercel vercel bot temporarily deployed to Preview – app January 29, 2026 04:18 Inactive
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@vercel vercel bot temporarily deployed to Preview – portal January 29, 2026 04:33 Inactive
@vercel vercel bot temporarily deployed to Preview – app January 29, 2026 04:33 Inactive
@tofikwest tofikwest merged commit b106216 into main Jan 29, 2026
10 checks passed
@tofikwest tofikwest deleted the tofik/aws-integration-fix branch January 29, 2026 04:44
@claudfuen
Copy link
Contributor

🎉 This PR is included in version 1.80.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants