Skip to content

[dev] [carhartlewis] lewis/comp-sub-processors#2096

Merged
carhartlewis merged 4 commits intomainfrom
lewis/comp-sub-processors
Feb 3, 2026
Merged

[dev] [carhartlewis] lewis/comp-sub-processors#2096
carhartlewis merged 4 commits intomainfrom
lewis/comp-sub-processors

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 3, 2026

This is an automated pull request to merge lewis/comp-sub-processors into dev.
It was created by the [Auto Pull Request] action.

@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Feb 3, 2026 1:52pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped Feb 3, 2026 1:52pm

Request Review

@cursor
Copy link

cursor bot commented Feb 3, 2026

PR Summary

Medium Risk
Introduces a new persistent Vendor.isSubProcessor column and threads it through API contracts and the update flow; main risk is migration/backfill correctness and ensuring all vendor create/update paths handle the new field consistently.

Overview
Adds a new vendor attribute, isSubProcessor (default false), persisted in the database via a Prisma migration and exposed in the API’s create and response DTOs (and regenerated openapi.json).

Updates the app to carry this field through vendor types/hooks and the vendor update action, and adds a checkbox to the vendor “secondary fields” form to edit it; after a successful update the vendor detail view triggers an SWR refresh to reflect changes immediately.

Written by Cursor Bugbot for commit 5b37071. This will update automatically on new commits. Configure here.

@carhartlewis carhartlewis merged commit 4037893 into main Feb 3, 2026
9 checks passed
@carhartlewis carhartlewis deleted the lewis/comp-sub-processors branch February 3, 2026 15:21
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

residualProbability: 'very_unlikely' as const,
residualImpact: 'insignificant' as const,
website: null,
isSubProcessor: false,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated placeholder vendor object structure

Low Severity

The pendingVendors (lines 263-281) and tempVendors (lines 285-303) mappings construct identical 18-property vendor objects. Adding isSubProcessor: false to both places highlights this duplication. Extract a helper function like createPlaceholderVendor(item, orgId) to centralize the object structure.

Fix in Cursor Fix in Web

@claudfuen
Copy link
Contributor

🎉 This PR is included in version 1.82.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants