Skip to content

chore(api): simplify Dockerfile by removing build tools installation#2198

Merged
Marfuen merged 1 commit intomainfrom
mariano/fix-issues-api-3
Feb 27, 2026
Merged

chore(api): simplify Dockerfile by removing build tools installation#2198
Marfuen merged 1 commit intomainfrom
mariano/fix-issues-api-3

Conversation

@Marfuen
Copy link
Contributor

@Marfuen Marfuen commented Feb 27, 2026

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes COMP-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel
Copy link

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
app Skipped Skipped Feb 27, 2026 2:10am
portal Skipped Skipped Feb 27, 2026 2:10am

Request Review

@cursor
Copy link

cursor bot commented Feb 27, 2026

PR Summary

Medium Risk
Build output is unchanged, but the runtime image no longer installs compilers or runs npm rebuild, which can break startup if any dependency expects native modules to be rebuilt against the node:20-slim environment.

Overview
Simplifies apps/api/Dockerfile.multistage production stage by removing installation of build toolchain (python/make/g++), dropping the npm rebuild step, and eliminating the apt cleanup that followed.

Keeps runtime Prisma generation, but now only runs npx prisma generate in the runtime image.

Written by Cursor Bugbot for commit 4ba9112. This will update automatically on new commits. Configure here.

@Marfuen Marfuen merged commit 49972e6 into main Feb 27, 2026
9 checks passed
@Marfuen Marfuen deleted the mariano/fix-issues-api-3 branch February 27, 2026 02:10
@claudfuen
Copy link
Contributor

🎉 This PR is included in version 1.86.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants