Skip to content

[dev] [tofikwest] fix/device-agent-duplicate-serial-registration#2202

Merged
tofikwest merged 2 commits intomainfrom
fix/device-agent-duplicate-serial-registration
Mar 1, 2026
Merged

[dev] [tofikwest] fix/device-agent-duplicate-serial-registration#2202
tofikwest merged 2 commits intomainfrom
fix/device-agent-duplicate-serial-registration

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 1, 2026

This is an automated pull request to merge fix/device-agent-duplicate-serial-registration into dev.
It was created by the [Auto Pull Request] action.

@cursor
Copy link

cursor bot commented Mar 1, 2026

PR Summary

Medium Risk
Changes device registration behavior to create/update records instead of rejecting when a serial number collides across members, which can impact identity/uniqueness semantics and may increase device record duplication if the heuristic is wrong.

Overview
Resolves duplicate/generic device serial collisions during agent registration: when a serial is already claimed by another member in the same org, the API now creates/updates a per-user device using a generated fallback:<originalSerial>:<uuid> serial (keyed by hostname + member) instead of returning a 409.

Updates the device details UI to hide these fallback values and display "Generic serial number" for any serial starting with fallback:.

Written by Cursor Bugbot for commit ea51af8. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Mar 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
portal Ready Ready Preview, Comment Mar 1, 2026 9:51pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
app Skipped Skipped Mar 1, 2026 9:51pm

Request Review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@vercel vercel bot temporarily deployed to Preview – app March 1, 2026 21:48 Inactive
@tofikwest tofikwest merged commit 5e6a5ca into main Mar 1, 2026
10 checks passed
@tofikwest tofikwest deleted the fix/device-agent-duplicate-serial-registration branch March 1, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant