Skip to content

[comp] Production Deploy#2297

Merged
Marfuen merged 11 commits intoreleasefrom
main
Mar 13, 2026
Merged

[comp] Production Deploy#2297
Marfuen merged 11 commits intoreleasefrom
main

Conversation

@github-actions
Copy link
Contributor

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.

github-actions bot and others added 11 commits March 12, 2026 20:07
Adds design spec for migrating training video completion flow from
direct DB access to RBAC-guarded NestJS API endpoints with SWR hooks
for reactive UI updates.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Includes GET and POST methods for retrieving and marking training video completions, requiring session authentication. Updates .gitignore to exclude superpowers directory.
Introduces a new test suite to verify that the addition of the `portal` resource does not affect the existing permissions of built-in roles. The tests cover various roles including owner, admin, auditor, and employee, ensuring that permissions are correctly defined and maintained.
[dev] [Marfuen] mariano/fix-training-videos
@cursor
Copy link

cursor bot commented Mar 13, 2026

PR Summary

Medium Risk
Introduces new RBAC-protected endpoints and permission resource (portal) for self-service training completion; mistakes could break employee onboarding flows or unintentionally widen/narrow access. Also changes client-side data fetching/mutation behavior, which may affect completion state consistency and email triggering.

Overview
Migrates portal training video completion from a Next.js route that wrote directly to the DB to RBAC-guarded NestJS endpoints: GET /v1/training/completions and POST /v1/training/completions/:videoId/complete (with member/org validation, video ID validation, and optional completion-email triggering).

Adds a new portal permission resource (granted to owner, admin, employee, contractor; excluded from auditor) and wires portal UI (EmployeeTasksList, GeneralTrainingAccordionItem, VideoCarousel) to a new useTrainingCompletions SWR hook for reactive progress updates and optimistic completion writes. Removes the old apps/portal mark-video-completed API route, updates OpenAPI, and adds regression/controller tests to lock down permissions and decorator requirements.

Written by Cursor Bugbot for commit fce34d3. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app (staging) Ready Ready Preview, Comment Mar 13, 2026 5:27pm
portal (staging) Ready Ready Preview, Comment Mar 13, 2026 5:27pm

Request Review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@Marfuen Marfuen merged commit bc832cf into release Mar 13, 2026
13 checks passed
@claudfuen
Copy link
Contributor

🎉 This PR is included in version 3.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants