[dev] [carhartlewis] lewis/comp-admin-dashboard#2313
Merged
Conversation
… with audit logging - Implemented AdminContextController and AdminFindingsController for managing context entries and findings within organizations. - Added AdminAuditLogInterceptor to log changes made through the admin endpoints. - Created corresponding service methods and DTOs for context and findings management. - Included unit tests for all new controllers to ensure functionality and reliability.
…omp-admin-dashboard
…oller - Updated limit and offset parameters to ensure they are properly constrained and converted to strings. - Improved handling of pagination values to prevent invalid inputs.
- Changed `findUnique` to `findFirst` for database queries in admin audit log tests. - Updated `memberId` type to allow null in `FindingAuditParams` and related service methods. - Modified admin findings controller to handle null `memberId` when creating audit logs. - Enhanced audit logging to skip entries if no active organization ID is present in the session.
… log interceptor - Added new audit log descriptions for user impersonation, session revocation, and user removal actions. - Replaced `AdminAuditLogInterceptor` with `PlatformAuditLogInterceptor` in the AdminIntegrationsController for improved logging. - Implemented `PlatformAuditLogInterceptor` to log platform credential changes with user context and action descriptions.
…ling - Modified admin findings controller test to handle null `memberId` when creating audit logs. - Enhanced admin organizations service test to include additional search criteria for members with the role of 'owner' based on user name and email.
…ove user role update logic - Updated admin policies controller to set frequency to null instead of undefined when the body frequency is null. - Enhanced user role update logic in auth server to fetch current user data before checking platform admin status, ensuring accurate updates.
- Updated limit and offset parameters in AdminEvidenceController, AdminOrganizationsController, AdminFindingsController, AdminTasksController, and AdminVendorsController to ensure proper parsing and default values. - Moved AdminRequest interface to platform-admin-auth-context for better type management and consistency across controllers.
- Updated AdminIntegrationsController to simplify credential hint retrieval by removing unnecessary async calls and integrating hints directly into the response. - Refactored credential handling in PlatformCredentialRepository to include client ID and secret hints. - Added client ID and secret hint properties to CreatePlatformCredentialDto and updated related service methods for consistent credential management. - Introduced a static method in OAuthCredentialsService to mask secrets for improved security.
…service - Updated the revokeInvitation method to check for 'pending' status when retrieving invitations, ensuring only valid invitations can be revoked. - Enhanced the NotFoundException message for better clarity on the invitation status.
…omp-admin-dashboard
…mpai/comp into lewis/comp-admin-dashboard
…r navigation and enhance AddFrameworkModal with session-based permission checks
…nd session notifications
…ility and maintainability
…ing and readability
…ctly and remove redundant column
PR SummaryMedium Risk Overview Updates Written by Cursor Bugbot for commit c5f3584. This will update automatically on new commits. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
packages/db/prisma/migrations/20260316000000_migrate_is_platform_admin_to_role/migration.sql
Show resolved
Hide resolved
Marfuen
approved these changes
Mar 16, 2026
…ons in permissions module
Marfuen
approved these changes
Mar 16, 2026
Marfuen
approved these changes
Mar 16, 2026
Contributor
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to merge lewis/comp-admin-dashboard into dev.
It was created by the [Auto Pull Request] action.