Skip to content

CS-168 Filter employees based on org unit and filter mode in employee-access check#2358

Merged
tofikwest merged 2 commits intomainfrom
chas/google-workspace-users
Mar 23, 2026
Merged

CS-168 Filter employees based on org unit and filter mode in employee-access check#2358
tofikwest merged 2 commits intomainfrom
chas/google-workspace-users

Conversation

@github-actions
Copy link
Contributor

This is an automated pull request to merge chas/google-workspace-users into dev.
It was created by the [Auto Pull Request] action.

@vercel
Copy link

vercel bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Mar 23, 2026 3:21am
comp-framework-editor Ready Ready Preview, Comment Mar 23, 2026 3:21am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped Mar 23, 2026 3:21am

Request Review

@cursor
Copy link

cursor bot commented Mar 23, 2026

PR Summary

Medium Risk
Changes which Google Workspace users are evaluated by security checks by applying org-unit and include/exclude email rules (and suspended handling) consistently; misconfiguration or logic edge cases could cause users to be incorrectly included/excluded from check results.

Overview
Adds a shared Google Workspace user-filtering utility (OU scoping, suspended/archived handling, and sync-style include/exclude email terms) and unit tests for it.

Updates the two-factor-auth and employee-access checks to use this centralized filter, and expands employee-access to accept target_org_units so both checks follow the same selection rules as employee sync.

Written by Cursor Bugbot for commit 0408858. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@chasprowebdev chasprowebdev changed the title [dev] [chasprowebdev] chas/google-workspace-users CS-168 Filter employees based on org unit and filter mode in employee-access check Mar 23, 2026
@linear
Copy link

linear bot commented Mar 23, 2026

Copy link
Contributor

@tofikwest tofikwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@tofikwest tofikwest merged commit 3266427 into main Mar 23, 2026
11 checks passed
@tofikwest tofikwest deleted the chas/google-workspace-users branch March 23, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants