Skip to content

[dev] [Marfuen] mariano/fix-trust-portal-dns-check#2463

Merged
Marfuen merged 1 commit intomainfrom
mariano/fix-trust-portal-dns-check
Apr 6, 2026
Merged

[dev] [Marfuen] mariano/fix-trust-portal-dns-check#2463
Marfuen merged 1 commit intomainfrom
mariano/fix-trust-portal-dns-check

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Apr 6, 2026

This is an automated pull request to merge mariano/fix-trust-portal-dns-check into dev.
It was created by the [Auto Pull Request] action.

@Marfuen @claude
fix(trust-portal): replace networkcalc.com DNS checks with Node built…
b49fb4e 
…-in resolver

The DNS verification for custom trust portal domains was failing because
it relied on networkcalc.com, an unreliable external API. This caused
domainVerified to stay false, which made the trust portal middleware
redirect custom domains to trycomp.ai instead of serving the portal.

Replaced with Node's built-in dns.promises resolver (matching the
existing server action pattern). Also removed axios dependency from
the service, replacing it with native fetch for Vercel API calls.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 6, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comp-framework-editor Ready Ready Preview, Comment Apr 6, 2026 8:08pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
app Skipped Skipped Apr 6, 2026 8:08pm
portal Skipped Skipped Apr 6, 2026 8:08pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 6, 2026 •
edited
Loading

PR Summary

Medium Risk
Updates custom-domain provisioning and DNS verification paths by replacing HTTP clients and changing DNS resolution behavior, which could affect domain verification outcomes in production. Risk is moderate because it touches Vercel API error handling and the trust portal domain publishing flow.

Overview
Improves trust portal custom-domain handling and DNS verification. The service now uses a centralized vercelFetch wrapper (built on fetch) instead of axios, standardizing auth token usage and surfacing Vercel HTTP status/response data for conflict handling and logging.

DNS record verification no longer depends on an external lookup API. checkDnsRecords now resolves CNAME/TXT records via Node’s dns.promises, updates TXT matching logic to align with Node’s return shapes, and continues to refresh/sync Vercel verification state before optionally triggering Vercel re-verification.

Reviewed by Cursor Bugbot for commit b49fb4e. Bugbot is set up for automated code reviews on this repo. Configure here.

@Marfuen Marfuen merged commit 32a97fa into main Apr 6, 2026
11 checks passed
@Marfuen Marfuen deleted the mariano/fix-trust-portal-dns-check branch April 6, 2026 20:11
claudfuen pushed a commit that referenced this pull request Apr 6, 2026
@semantic-release-bot
chore(release): 3.16.0 [skip ci]
d24998d 
# [3.16.0](v3.15.1...v3.16.0) (2026-04-06)

### Bug Fixes

* **frameworks:** remove max-w constraint that clips description text in tables ([#2461](#2461)) ([218a789](218a789))
* Statement of Applicability only allows you to change answers from Yes to No and not the other way around ([d164c77](d164c77))
* **trust-portal:** replace networkcalc.com DNS checks with Node built-in resolver ([#2463](#2463)) ([32a97fa](32a97fa))

### Features

* enhance vendor research and improve ui for it ([7a08b2c](7a08b2c))
@claudfuen
Copy link
Copy Markdown
Contributor

claudfuen commented Apr 6, 2026

🎉 This PR is included in version 3.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automated-pr released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@claudfuen @Marfuen