Skip to content

[dev] [cursor[bot]] cursor/submission-wizard-file-handling-ca3e#2473

Closed
github-actions[bot] wants to merge 2 commits intomainfrom
cursor/submission-wizard-file-handling-ca3e
Closed

[dev] [cursor[bot]] cursor/submission-wizard-file-handling-ca3e#2473
github-actions[bot] wants to merge 2 commits intomainfrom
cursor/submission-wizard-file-handling-ca3e

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Apr 7, 2026

This is an automated pull request to merge cursor/submission-wizard-file-handling-ca3e into dev.
It was created by the [Auto Pull Request] action.

tofikwest and others added 2 commits April 7, 2026 11:24
Customers could only upload PDFs and images when submitting evidence.
Added CSV, XLSX, and XLS support to the file type mapper and evidence
form definitions (whistleblower-report, tabletop-exercise). Also added
an optional spreadsheet upload field to the RBAC matrix form so users
can upload their matrix as a file instead of entering rows manually.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 7, 2026

PR Summary

Medium Risk
Updates form validation to allow RBAC submissions via either matrix rows or an uploaded file, which can change what payloads are considered valid. Also expands accepted upload MIME types, so reviewers should confirm backend upload handling supports the new file formats.

Overview
Adds spreadsheet upload support to evidence submissions by expanding accepted file types to include .csv, .xlsx, and .xls (alongside existing document/image types).

For the rbac-matrix form, introduces an optional matrixFile upload as an alternative to manually entering matrixRows, and updates both the client wizard and Zod schema so either a file or at least one non-empty, fully-valid row is required.

Refactors the submission wizard’s FileUploader configuration by centralizing extension-to-MIME mapping in buildFileAcceptMap() and reusing it across file fields.

Reviewed by Cursor Bugbot for commit c6b30e9. Bugbot is set up for automated code reviews on this repo. Configure here.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tofikwest
❌ cursoragent
You have signed the CLA already but the status is still pending? Let us recheck it.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Apr 7, 2026 3:44pm
comp-framework-editor Ready Ready Preview, Comment Apr 7, 2026 3:44pm
portal Ready Ready Preview, Comment Apr 7, 2026 3:44pm

Request Review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c6b30e9. Configure here.

)
: { 'application/pdf': [], 'image/*': [], 'text/*': [] }
}
accept={buildFileAcceptMap(field.accept)}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File upload renders above matrix rows, inverting intended order

Medium Severity

For the rbac-matrix form, the matrixFile field (type file) is categorized into extendedFields and the matrixRows field (type matrix) into matrixFields. Since step 2 renders extendedFields before matrixFields, the file uploader appears above the matrix rows. This contradicts the definition order and the matrixFile description text which reads "instead of entering rows above" — there are no rows above it. The primary input (matrix) ends up below the secondary alternative (file upload), creating a confusing UX.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit c6b30e9. Configure here.

@cursor cursor bot closed this Apr 7, 2026
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 7, 2026

Automatically closed this PR because it was created by Bugbot autofix for #2471, and that PR was closed.

@cursor cursor bot deleted the cursor/submission-wizard-file-handling-ca3e branch April 7, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants