Skip to content

[dev] [cursor[bot]] cursor/trigger-task-logic-issues-f845#2477

Closed
github-actions[bot] wants to merge 3 commits intomainfrom
cursor/trigger-task-logic-issues-f845
Closed

[dev] [cursor[bot]] cursor/trigger-task-logic-issues-f845#2477
github-actions[bot] wants to merge 3 commits intomainfrom
cursor/trigger-task-logic-issues-f845

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Apr 7, 2026

This is an automated pull request to merge cursor/trigger-task-logic-issues-f845 into dev.
It was created by the [Auto Pull Request] action.

Marfuen and others added 3 commits April 7, 2026 12:45
Add `await tags.add([`org:${organizationId}`])` to all 25 trigger tasks
that receive an organizationId, making it easy to filter and identify
which organization a job was run for in the trigger.dev dashboard.

Scheduled/bulk tasks that iterate over all orgs are excluded since they
don't have a single organizationId.

Also updates the vendor extraction prompt to prefer company names over
product names (e.g. "Anthropic" not "Claude", "OpenAI" not "ChatGPT").

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Apr 7, 2026 4:55pm
comp-framework-editor Ready Ready Preview, Comment Apr 7, 2026 4:55pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped Apr 7, 2026 4:55pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 7, 2026

PR Summary

Medium Risk
Broadly touches many Trigger.dev tasks to add per-organization tags, which is low behavioral risk but affects observability across critical background jobs. Also adjusts onboarding vendor extraction to normalize to parent-company names and track product aliases, which could change vendor matching/creation outcomes during onboarding.

Overview
Adds organization tagging across Trigger.dev jobs. Most API and app Trigger tasks now call tags.add([\org:${organizationId}`])` at the start so runs can be grouped/filtered by org in Trigger.dev.

Improves onboarding vendor extraction alias handling. extractVendorsFromContext now asks the model to prefer parent-company names and return mentioned product names in source_vendor_names, then uses those aliases when applying custom vendor URLs and when deciding whether a vendor from the “software” field was already extracted.

Reviewed by Cursor Bugbot for commit 2404e9b. Bugbot is set up for automated code reviews on this repo. Configure here.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Marfuen
❌ cursoragent
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2404e9b. Configure here.

type: 'object',
properties: {
vendor_name: { type: 'string' },
source_vendor_names: { type: 'array', items: { type: 'string' } },
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional schema field incompatible with OpenAI strict mode

High Severity

The source_vendor_names property is added to the JSON schema properties but not included in the required array, while additionalProperties: false is set. With @ai-sdk/openai@^3.0.0, strictJsonSchema defaults to true, and OpenAI's strict mode requires all properties to be listed in required when additionalProperties is false. This will cause the generateObject call to fail with a schema rejection error at runtime, breaking vendor extraction during onboarding. The field needs to be added to required and its type changed to allow null (e.g., anyOf: [{type: 'array', items: {type: 'string'}}, {type: 'null'}]).

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2404e9b. Configure here.

@cursor cursor bot closed this Apr 7, 2026
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 7, 2026

Automatically closed this PR because it was created by Bugbot autofix for #2476, and that PR was closed.

@cursor cursor bot deleted the cursor/trigger-task-logic-issues-f845 branch April 7, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants