Skip to content

chore: remove syncVercelEnvVars from Trigger configs#2504

Merged
Marfuen merged 2 commits intomainfrom
cleanup/remove-sync-vercel-env-vars
Apr 10, 2026
Merged

chore: remove syncVercelEnvVars from Trigger configs#2504
Marfuen merged 2 commits intomainfrom
cleanup/remove-sync-vercel-env-vars

Conversation

@claudfuen
Copy link
Copy Markdown
Contributor

Summary

  • Remove syncVercelEnvVars() from both app and API Trigger.dev configs
  • All required env vars are already set independently in Trigger's dashboard (staging + production)
  • Decouples Trigger env from Vercel env for proper isolation

Why

Trigger should manage its own env vars explicitly, not inherit from Vercel. This is a prerequisite for staging email isolation (separate Resend keys per environment).

🤖 Generated with Claude Code

Trigger.dev manages its own env vars independently.
All required vars are already set in Trigger's dashboard
for both staging and production.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Apr 10, 2026 6:34pm
comp-framework-editor Ready Ready Preview, Comment Apr 10, 2026 6:34pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped Apr 10, 2026 6:34pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 10, 2026

PR Summary

Low Risk
Removes an environment-variable sync mechanism, so misconfigured Trigger dashboard env vars could cause runtime failures, but the code change itself is small and localized to build config.

Overview
Removes syncVercelEnvVars() from both apps/api/trigger.config.ts and apps/app/trigger.config.ts, so Trigger jobs no longer inherit environment variables from Vercel at build time.

This decouples Trigger’s runtime configuration from Vercel and relies on env vars being managed directly in Trigger.

Reviewed by Cursor Bugbot for commit 1c040c0. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel vercel bot temporarily deployed to Preview – portal April 10, 2026 18:32 Inactive
@Marfuen Marfuen merged commit 56c67df into main Apr 10, 2026
8 of 9 checks passed
@Marfuen Marfuen deleted the cleanup/remove-sync-vercel-env-vars branch April 10, 2026 18:34
@claudfuen
Copy link
Copy Markdown
Contributor Author

🎉 This PR is included in version 3.20.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants