Skip to content

CS-234 Change Meeting Type when uploading an evidence#2514

Merged
Marfuen merged 2 commits intomainfrom
chas/evidence-meeting-type
Apr 16, 2026
Merged

CS-234 Change Meeting Type when uploading an evidence#2514
Marfuen merged 2 commits intomainfrom
chas/evidence-meeting-type

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Apr 13, 2026

This is an automated pull request to merge chas/evidence-meeting-type into dev.
It was created by the [Auto Pull Request] action.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 13, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Apr 16, 2026 2:07pm
comp-framework-editor Ready Ready Preview, Comment Apr 16, 2026 2:07pm
portal Ready Ready Preview, Comment Apr 16, 2026 2:07pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 13, 2026 •
edited
Loading

PR Summary

Medium Risk
Changes evidence upload behavior for meeting forms by letting users pick the target meeting subtype, which could route uploads to different endpoints if mis-selected. Also modifies the shared SelectContent portal mounting behavior, which may affect dropdown rendering/focus in other dialogs.

Overview
The evidence upload dialog for meeting documents now includes a Meeting type dropdown, and uploads are sent to the selected meeting subtype endpoint instead of defaulting to the first subtype.

The shared UI SelectContent component now accepts an optional container prop to mount the Radix portal within a specific element (used to ensure correct stacking/focus trapping inside the upload Dialog).

Reviewed by Cursor Bugbot for commit 9680d20. Bugbot is set up for automated code reviews on this repo. Configure here.

@chasprowebdev chasprowebdev changed the title [dev] [chasprowebdev] chas/evidence-meeting-type CS-234 Change Meeting Type when uploading an evidence Apr 13, 2026
@linear
Copy link
Copy Markdown

linear bot commented Apr 13, 2026

CS-234 Meeting Minutes Document meeting type cannot be changed

@chasprowebdev
Copy link
Copy Markdown
Contributor

chasprowebdev commented Apr 13, 2026

Recording

upload-evidence.mov

@Marfuen Marfuen merged commit 5bdf430 into main Apr 16, 2026
11 checks passed
@Marfuen Marfuen deleted the chas/evidence-meeting-type branch April 16, 2026 19:29
claudfuen pushed a commit that referenced this pull request Apr 16, 2026
@semantic-release-bot
chore(release): 3.23.0 [skip ci]
15c6037 
# [3.23.0](v3.22.4...v3.23.0) (2026-04-16)

### Bug Fixes

* **app:** able to change meeting type when uploading evidence ([#2514](#2514)) ([5bdf430](5bdf430))
* fix missing DNS records coming from Vercel ([eab60fe](eab60fe))
* **trust-portal:** trust Vercel verdict for custom domain DNS verification ([3f4faf2](3f4faf2))

### Features

* **app:** adding findings section on People page tabs ([9241d3f](9241d3f)), closes [#finding-](https://github.com/trycompai/comp/issues/finding-)
@claudfuen
Copy link
Copy Markdown
Contributor

claudfuen commented Apr 16, 2026

🎉 This PR is included in version 3.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Marfuen Marfuen Awaiting requested review from Marfuen

@tofikwest tofikwest Awaiting requested review from tofikwest

Assignees

No one assigned

Labels

automated-pr released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chasprowebdev @claudfuen @Marfuen