Skip to content

fix(api): use relative path for dynamic import of S3 presigner#2523

Merged
tofikwest merged 1 commit intomainfrom
fix/api-dynamic-import-s3-presigner
Apr 13, 2026
Merged

fix(api): use relative path for dynamic import of S3 presigner#2523
tofikwest merged 1 commit intomainfrom
fix/api-dynamic-import-s3-presigner

Conversation

@tofikwest
Copy link
Copy Markdown
Contributor

Summary

Changes

  • apps/api/src/policies/policies.controller.ts — 2 lines: await import('@/app/s3')await import('../app/s3')

Test plan

  • Verify API Docker build passes (CodeBuild)

🤖 Generated with Claude Code

Dynamic import() doesn't resolve @/ path aliases in nest build,
causing the Docker/CodeBuild API build to fail with TS2307.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comp-framework-editor Building Building Preview, Comment Apr 13, 2026 3:32pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
app Skipped Skipped Apr 13, 2026 3:32pm
portal Skipped Skipped Apr 13, 2026 3:32pm

Request Review

@vercel vercel Bot temporarily deployed to Preview – app April 13, 2026 15:32 Inactive
@vercel vercel Bot temporarily deployed to Preview – portal April 13, 2026 15:32 Inactive
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 13, 2026

PR Summary

Low Risk
Low risk: only adjusts module resolution for two dynamic imports and does not change S3 signing logic or request behavior.

Overview
Fixes API build/runtime module resolution for PDF download links.

Updates policies.controller.ts to dynamically import getSignedUrl from ../app/s3 (instead of @/app/s3) in both signed-URL code paths so Nest/Docker builds that don’t honor TS path aliases can compile successfully.

Reviewed by Cursor Bugbot for commit 068e487. Bugbot is set up for automated code reviews on this repo. Configure here.

@tofikwest tofikwest merged commit 5efbe13 into main Apr 13, 2026
9 of 11 checks passed
@tofikwest tofikwest deleted the fix/api-dynamic-import-s3-presigner branch April 13, 2026 15:33
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants