fix(api): use relative path for dynamic import of S3 presigner#2523
Merged
fix(api): use relative path for dynamic import of S3 presigner#2523
Conversation
Dynamic import() doesn't resolve @/ path aliases in nest build, causing the Docker/CodeBuild API build to fail with TS2307. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Updates Reviewed by Cursor Bugbot for commit 068e487. Bugbot is set up for automated code reviews on this repo. Configure here. |
Contributor
|
🎉 This PR is included in version 3.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TS2307: Cannot find module '@/app/s3')import()doesn't resolve@/path aliases innest build— changed to relative../app/s3Changes
apps/api/src/policies/policies.controller.ts— 2 lines:await import('@/app/s3')→await import('../app/s3')Test plan
🤖 Generated with Claude Code