fix(cloud): clear reconnect warning after successful OAuth reconnect#2537
Merged
fix(cloud): clear reconnect warning after successful OAuth reconnect#2537
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
🎉 This PR is included in version 3.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:\n- store reconnect timestamp after successful cloud OAuth reconnect\n- use reconnect timestamp in cloud reconnect policy so warning clears correctly\n- pass reconnect timestamp through cloud providers and integration detail reconnect checks\n- add reconnect policy tests for reconnect marker behavior\n\nValidation:\n- apps/app vitest cloud reconnect policy and tests layout\n- apps/api bun run build
Summary by cubic
Fixes cloud OAuth reconnect banners not clearing. We now record a reconnect timestamp and use it in the reconnect policy and UI so the warning disappears after a successful reconnect.
reconnectedAtin connection metadata inapps/apiOAuthController.reconnectedAtfrom the API and into the app (CloudSecurityQueryService, app provider types).requiresCloudReconnectto considerreconnectedAtagainst the cutoff; add unit tests.reconnectedAtinto UI checks in cloud tests and provider detail views to clear the banner.Written for commit 4faab40. Summary will update on new commits.