Skip to content

fix(cloud): clear reconnect warning after successful OAuth reconnect#2537

Merged
tofikwest merged 1 commit intomainfrom
fix/cloud-reconnect-oauth-clear
Apr 13, 2026
Merged

fix(cloud): clear reconnect warning after successful OAuth reconnect#2537
tofikwest merged 1 commit intomainfrom
fix/cloud-reconnect-oauth-clear

Conversation

@tofikwest
Copy link
Copy Markdown
Contributor

@tofikwest tofikwest commented Apr 13, 2026

Summary:\n- store reconnect timestamp after successful cloud OAuth reconnect\n- use reconnect timestamp in cloud reconnect policy so warning clears correctly\n- pass reconnect timestamp through cloud providers and integration detail reconnect checks\n- add reconnect policy tests for reconnect marker behavior\n\nValidation:\n- apps/app vitest cloud reconnect policy and tests layout\n- apps/api bun run build


Summary by cubic

Fixes cloud OAuth reconnect banners not clearing. We now record a reconnect timestamp and use it in the reconnect policy and UI so the warning disappears after a successful reconnect.

  • Bug Fixes
    • On cloud OAuth success, save reconnectedAt in connection metadata in apps/api OAuthController.
    • Expose reconnectedAt from the API and into the app (CloudSecurityQueryService, app provider types).
    • Update requiresCloudReconnect to consider reconnectedAt against the cutoff; add unit tests.
    • Pass reconnectedAt into UI checks in cloud tests and provider detail views to clear the banner.

Written for commit 4faab40. Summary will update on new commits.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Apr 13, 2026 9:59pm
comp-framework-editor Ready Ready Preview, Comment Apr 13, 2026 9:59pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped Apr 13, 2026 9:59pm

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Auto-approved: Fixes persistent cloud reconnect banners by tracking and checking a 'reconnectedAt' timestamp. Low-risk logic update with corresponding unit tests.

@tofikwest tofikwest merged commit 6a0397a into main Apr 13, 2026
11 checks passed
@tofikwest tofikwest deleted the fix/cloud-reconnect-oauth-clear branch April 13, 2026 22:00
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants