SALE-34: Sort policies alphabetically by default#2541
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 6 files
Auto-approved: Safe UI enhancement: sets default policy sorting to alphabetical across the app and portal using a deterministic helper. Low risk, includes unit tests.
Linked issue analysis
Linked issue: SALE-34: Sort policies alphabetically by default
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Policies should be sorted alphabetically by default (app policy list) | Default sort set to name ASC and comparator applied |
| ✅ | Apply alphabetical sorting in portal dashboard (OrganizationDashboard) | OrganizationDashboard wraps DB fetch with sortPoliciesByName |
| ✅ | Apply alphabetical ordering in employee portal signed policies list | Signed policies page sorts results with sortPoliciesByName |
Contributor
|
🎉 This PR is included in version 3.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Summary by cubic
Policies now default to alphabetical order (case-insensitive, stable) across the app and employee portal. This cleans up policy lists and fulfills Linear SALE-34.
nameASC in appPolicyFilters.localeComparewithcomparePoliciesByName(usesIntl.Collator, ties break byid).sortPoliciesByNameinOrganizationDashboardand signed policies page (after fetch for deterministic order).Written for commit ced89c2. Summary will update on new commits.