[dev] [carhartlewis] lewis/comp-people-perf-fixes-2#2587
Merged
Conversation
- Guard host.mdm access in fleet-hosts route to avoid runtime TypeError - Show loading/error states in DevicesTabContent so the compliance chart no longer flashes an empty-state while fetching - Render a skeleton in the MemberRow device column while device data loads instead of defaulting to 'Not Installed' - Replace hand-rolled button styles on PopoverTrigger with base-ui render pattern using Button Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Lewis Carhart seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
claudfuen
pushed a commit
that referenced
this pull request
Apr 17, 2026
## [3.23.4](v3.23.3...v3.23.4) (2026-04-17) ### Bug Fixes * **people:** address review feedback on devices and export button ([#2587](#2587)) ([ca71fa8](ca71fa8))
Contributor
|
🎉 This PR is included in version 3.23.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to merge lewis/comp-people-perf-fixes-2 into dev.
It was created by the [Auto Pull Request] action.
Summary by cubic
Improves device status UX and stability across People pages by adding loading/error states and fixing a fleet hosts API crash. Also standardizes the Export Evidence trigger to use the base
Button.Bug Fixes
host.mdm?.connected_to_fleetin/api/people/fleet-hosts.Refactors
Button variant="outline"in Export Evidence.useAgentDevicesanduseFleetHoststhrough TeamMembersClient to MemberRow for accurate loading states.Written for commit def8177. Summary will update on new commits.