Skip to content

[dev] [carhartlewis] lewis/comp-framework-controls-fix#2602

Merged
carhartlewis merged 1 commit intomainfrom
lewis/comp-framework-controls-fix
Apr 20, 2026
Merged

[dev] [carhartlewis] lewis/comp-framework-controls-fix#2602
carhartlewis merged 1 commit intomainfrom
lewis/comp-framework-controls-fix

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Apr 20, 2026

This is an automated pull request to merge lewis/comp-framework-controls-fix into dev.
It was created by the [Auto Pull Request] action.


Summary by cubic

Fixes framework compliance scoring by excluding controls with no artifacts from the calculation and improves control options fetching with org-scoped caching. Also resets the Add Custom Requirement form when the sheet closes.

  • Bug Fixes

    • Exclude controls without policies, tasks, or document types from scoring to avoid unfairly lowering scores.
    • Reset identifier, name, and description when the Add Custom Requirement sheet closes.
  • Refactors

    • Switch useControlOptions to useApiSWR for org-scoped cache invalidation on /v1/controls/options and adapt to data.data response shape.

Written for commit e3b58bc. Summary will update on new commits.

- useControlOptions: switch to useApiSWR for org-scoped cache invalidation
- AddCustomRequirementSheet: reset form state when sheet closes
- frameworks-scores: exclude controls without artifacts from score
  calculation instead of counting them as incomplete

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Apr 20, 2026 4:32pm
comp-framework-editor Ready Ready Preview, Comment Apr 20, 2026 4:32pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped Apr 20, 2026 4:32pm

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Requires human review: Changes to framework compliance scoring logic in frameworks-scores.helper.ts modify core business logic and should be reviewed by a human.

@carhartlewis carhartlewis merged commit e4fbb8c into main Apr 20, 2026
11 checks passed
@carhartlewis carhartlewis deleted the lewis/comp-framework-controls-fix branch April 20, 2026 16:55
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants