Skip to content

[comp] Production Deploy#2625

Merged
Marfuen merged 2 commits intoreleasefrom
main
Apr 21, 2026
Merged

[comp] Production Deploy#2625
Marfuen merged 2 commits intoreleasefrom
main

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Apr 21, 2026

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.


Summary by cubic

Fixes duplicate policy acknowledgment digest emails by rolling up recipients across orgs by normalized email instead of user.id. Ensures each person gets one digest even if they have multiple user records.

  • Bug Fixes
    • Dedup digest recipients by normalized email, not user.id, to handle non-unique emails in the schema.
    • Added a regression test covering two orgs with the same email (different user IDs and casing) to ensure a single email is sent.

Written for commit 75c8888. Summary will update on new commits.

github-actions Bot and others added 2 commits April 21, 2026 17:16
…2624)

User.email is not @unique in the schema, so the same person can end up
with multiple user rows — typically when invited to separate orgs through
different flows. Keying the rollup on user.id split those duplicates into
one email per row, which is why a user with memberships across 8 orgs
received two separate digests within a minute of each other (one per
duplicated user record, each branded from a different primaryOrgId).

Key the dedup map on the normalized email address instead so one person
always gets one digest regardless of how many user rows back their memberships.

Added a regression test covering two orgs, same email, different user.ids.

Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app (staging) Ready Ready Preview, Comment Apr 21, 2026 6:51pm
comp-framework-editor Ready Ready Preview, Comment Apr 21, 2026 6:51pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal (staging) Skipped Skipped Apr 21, 2026 6:51pm

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Requires human review: This PR contains a logic change to how recipients are identified in a business-critical notification task and is a production deployment, which warrants human verification.

@Marfuen Marfuen merged commit bd75bb2 into release Apr 21, 2026
14 checks passed
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.27.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants