fix(db): exclude *.spec.ts from tsc build#2651
Merged
Conversation
packages/db/tsconfig only excluded *.test.ts, but the framework-versioning backfill spec is named *.spec.ts (and imports from bun:test). tsc picked it up during the API's Docker image build and failed with TS2307 on bun:test. Verified locally by running `docker build -f apps/api/Dockerfile.multistage --target builder` through to completion. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 3.31.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packages/db/tsconfig only excluded *.test.ts, but the framework-versioning backfill spec is named *.spec.ts (and imports from bun:test). tsc picked it up during the API's Docker image build and failed with TS2307 on bun:test.
Verified locally by running
docker build -f apps/api/Dockerfile.multistage --target builderthrough to completion.What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
Summary by cubic
Exclude *.spec.ts from the
packages/dbTypeScript build. This stops tsc from compiling Bun-based specs and fixes API Docker builder failures (TS2307 onbun:test).Written for commit 77922f2. Summary will update on new commits.