Skip to content

fix(db): exclude *.spec.ts from tsc build#2651

Merged
Marfuen merged 1 commit intomainfrom
mariano/fix-db-build-spec-exclude
Apr 23, 2026
Merged

fix(db): exclude *.spec.ts from tsc build#2651
Marfuen merged 1 commit intomainfrom
mariano/fix-db-build-spec-exclude

Conversation

@Marfuen
Copy link
Copy Markdown
Contributor

@Marfuen Marfuen commented Apr 23, 2026

packages/db/tsconfig only excluded *.test.ts, but the framework-versioning backfill spec is named *.spec.ts (and imports from bun:test). tsc picked it up during the API's Docker image build and failed with TS2307 on bun:test.

Verified locally by running docker build -f apps/api/Dockerfile.multistage --target builder through to completion.

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes COMP-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Summary by cubic

Exclude *.spec.ts from the packages/db TypeScript build. This stops tsc from compiling Bun-based specs and fixes API Docker builder failures (TS2307 on bun:test).

Written for commit 77922f2. Summary will update on new commits.

packages/db/tsconfig only excluded *.test.ts, but the framework-versioning
backfill spec is named *.spec.ts (and imports from bun:test). tsc picked it
up during the API's Docker image build and failed with TS2307 on bun:test.

Verified locally by running `docker build -f apps/api/Dockerfile.multistage
--target builder` through to completion.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Building Building Preview, Comment Apr 23, 2026 9:38pm
comp-framework-editor Building Building Preview, Comment Apr 23, 2026 9:38pm
portal Building Building Preview, Comment Apr 23, 2026 9:38pm

Request Review

@Marfuen Marfuen merged commit 4d340ad into main Apr 23, 2026
6 of 9 checks passed
@Marfuen Marfuen deleted the mariano/fix-db-build-spec-exclude branch April 23, 2026 21:38
claudfuen pushed a commit that referenced this pull request Apr 23, 2026
# [3.31.0](v3.30.0...v3.31.0) (2026-04-23)

### Bug Fixes

* **db:** exclude *.spec.ts from tsc build ([#2651](#2651)) ([4d340ad](4d340ad))

### Features

* enabled framework versioning and updating existing frameworks when new versions come out ([7518075](7518075))
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.31.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants