Conversation
DescribeFlowLogs does not support a `resource-type` filter — the supported filters per the AWS SDK are resource-id, flow-log-id, log-group-name, log-destination-type, deliver-log-status, traffic-type, and tag. Passing `resource-type` was undefined behavior and caused legitimate VPC-level flow logs to be missed, so customers who had correctly enabled flow logs still saw the "no flow logs enabled" finding. Drop the invalid filter, fetch all flow logs with pagination, and determine VPC-scope client-side by the `vpc-` ResourceId prefix. Subnet-scope and ENI-scope flow logs continue to be excluded because they do not cover all VPC traffic. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
fix(cloud-security): recognize VPC-scope flow logs correctly
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 3.31.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Fixes VPC flow log detection in AWS checks to stop false “no flow logs” findings. We now detect VPC-scope flow logs correctly by paginating all flow logs and matching
vpc-resources.resource-typefilter fromDescribeFlowLogsin@aws-sdk/client-ec2.ResourceIdprefixvpc-; ignoresubnet-andeni-logs.Written for commit 780928b. Summary will update on new commits.