[dev] [Marfuen] mariano/fix-primitive-create-no-auto-link#2686
Merged
Conversation
…ll framework controls
When CX created a new task or policy template from a framework's editor
view, the create endpoint queried every control template attached to
that framework and connected the new primitive to all of them. CX
rarely wants the new template on every control — it forced manual
cleanup after every create.
Make all primitives consistent: a fresh create produces an unlinked row
regardless of which framework page the user happened to be on. Linking
to specific controls happens explicitly via the dedicated link
endpoints (POST /:id/control-templates/:ctId), which already existed.
- task-template.service.ts: drop frameworkId param + the findMany
+ connect logic
- policy-template.service.ts: same
- task-template.controller.ts, policy-template.controller.ts: drop
the @query('frameworkId') from the POST handler
- frontend (useTaskChangeTracking, CreatePolicyDialog): stop appending
?frameworkId=... to the POST URL
Control template and requirement creates were already correct (no
auto-linking) — this brings task and policy templates in line.
New regression tests on TaskTemplateService and PolicyTemplateService
mirror the existing CS-271 guard on ControlTemplateService: even if a
stray frameworkId is passed, the service must not query for or attach
controls. Verified red without the fix, green with it.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 3.34.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to merge mariano/fix-primitive-create-no-auto-link into dev.
It was created by the [Auto Pull Request] action.
Summary by cubic
Stop auto-linking new task and policy templates to every control in a framework. New templates are created unlinked; linking happens later via the dedicated endpoints.
frameworkIdfrom task/policy create controllers and services; deleted control lookup/connect logic.CreatePolicyDialog,useTaskChangeTracking) to stop appending?frameworkId=...on POST.frameworkIdis provided.frequency: monthlyanddepartment: none; policies persist an emptycontentobject.Written for commit bb03f8e. Summary will update on new commits. Review in cubic