fix(frameworks): repair sync drift for controls and tasks#2729
Merged
fix(frameworks): repair sync drift for controls and tasks#2729
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 2 files
Requires human review: This change modifies core synchronization logic by altering how controls and tasks are reconciled during framework updates, which requires human verification of data integrity risks.
Linked issue analysis
Linked issue: CS-334: Framework version fails to pull in newly linked controls when upgrading in the app
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | When upgrading a framework in an existing org, newly linked controls for requirements must be pulled into the org | Creates control rows from target manifest before reconciling maps |
| ✅ | When upgrading, newly linked tasks for those controls must be pulled into the org | Creates task rows from target manifest before reconciling links |
| ✅ | Fix should be general across frameworks (e.g., SOC2 and ISO27001), not framework-specific | Logic operates on generic manifest arrays, not framework-specific code |
| Upgraded org behavior should match creating a new org with the same latest framework (result parity) | Tests create missing rows but don't assert full parity with new-org result | |
| ✅ | Ensure framework sync creates missing org control rows from the target manifest before reconciling requirement maps | Replaced diff.added loop with target-manifest creation prior to reconciling |
| ✅ | Ensure framework sync creates missing org task rows from the target manifest before reconciling control-task links | Replaced diff.tasks.added loop with target-manifest task creation prior to linking |
| ✅ | Add regression coverage for older-account drift where v1/v2 manifests claim rows that the customer DB is missing | Added unit tests that simulate missing control/task rows and assert creation |
Contributor
|
🎉 This PR is included in version 3.40.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Fixes CS-334