fix(cloud-tests): scope to aws/gcp/azure and remove hardcoded copy#2730
Merged
fix(cloud-tests): scope to aws/gcp/azure and remove hardcoded copy#2730
Conversation
Cloud Tests previously surfaced any integration with category 'Cloud', which incorrectly included Vercel. Filter the providers and findings queries by an explicit slug allowlist (aws, gcp, azure) so the page reflects what users actually expect. Also remove two hardcoded "exclusively for Cloud Security Tests" strings on the Integrations page and Connect dialog — they were gated on the same broken category check and showed up for Vercel too. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 3.40.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
category: 'Cloud', which leaked Vercel into the providers list and findings. Filter by an explicit slug allowlist (aws,gcp,azure) in the API service so only real cloud providers are returned.Files changed
apps/api/src/cloud-security/cloud-security-query.service.ts— replacecategory: 'Cloud'filter withslug IN ('aws','gcp','azure')for both new-platform connections and legacy integrations, in both providers and findings queries.apps/app/src/app/(app)/[orgId]/integrations/components/PlatformIntegrations.tsx— remove the italic "exclusively for Cloud Security Tests" line on integration cards.apps/app/src/components/integrations/ConnectIntegrationDialog.tsx— remove the same notice from the connect dialog.Test plan
🤖 Generated with Claude Code