Skip to content

Fix pentest scan setup review issues#2743

Merged
tofikwest merged 1 commit intomainfrom
fix/pentest-scan-review-issues
May 1, 2026
Merged

Fix pentest scan setup review issues#2743
tofikwest merged 1 commit intomainfrom
fix/pentest-scan-review-issues

Conversation

@tofikwest
Copy link
Copy Markdown
Contributor

@tofikwest tofikwest commented May 1, 2026

Summary

  • associate the optional repository field text with its input for screen readers
  • clamp custom runtime max to the already-clamped minimum to avoid inverted ranges
  • add focused regression coverage for both issues

Verification

  • cd apps/app && bunx vitest run 'src/app/(app)/[orgId]/security/penetration-tests/_components/CreateRunPanel.test.tsx'

Context: these were the two PR 2741 review findings identified by cubic, and both are valid.


Summary by cubic

Fixes two issues in the pentest scan setup: adds an accessible label for the optional Repository field and clamps the custom runtime range to prevent inverted values. Adds focused regression tests.

  • Bug Fixes
    • Associate the "Repository (optional)" label with its input via htmlFor/id for screen readers.
    • Clamp max runtime to at least the min in custom profiles, so empty selections show "5 min-5 min" instead of an inverted range.

Written for commit 6f11e03. Summary will update on new commits.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment May 1, 2026 10:56pm
comp-framework-editor Ready Ready Preview, Comment May 1, 2026 10:56pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped May 1, 2026 10:56pm

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@tofikwest tofikwest merged commit ab8f4b7 into main May 1, 2026
11 checks passed
@tofikwest tofikwest deleted the fix/pentest-scan-review-issues branch May 1, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant