Skip to content

Forward pentest create notification fields#2744

Merged
tofikwest merged 1 commit intomainfrom
fix/pentest-create-notification-payload
May 2, 2026
Merged

Forward pentest create notification fields#2744
tofikwest merged 1 commit intomainfrom
fix/pentest-create-notification-payload

Conversation

@tofikwest
Copy link
Copy Markdown
Contributor

@tofikwest tofikwest commented May 2, 2026

Summary

  • forward webhookUrl and notificationEmail in penetration test create requests
  • preserve those fields in the optimistic report cache after create
  • add regression coverage for the create request body

Verification

  • cd apps/app && bunx vitest run 'src/app/(app)/[orgId]/security/penetration-tests/hooks/use-penetration-tests.test.tsx'

Context: this addresses the production PR review finding identified by cubic.


Summary by cubic

Fix penetration test creation to include webhookUrl and notificationEmail, and keep them in the optimistic cache so notifications work and the UI reflects these fields immediately. Adds regression coverage to ensure these fields are posted.

  • Bug Fixes
    • Send webhookUrl and notificationEmail in the create request body.
    • Preserve these fields in the optimistic report cache after create.

Written for commit 96325ab. Summary will update on new commits.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment May 2, 2026 1:06am
comp-framework-editor Ready Ready Preview, Comment May 2, 2026 1:06am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped May 2, 2026 1:06am

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@tofikwest tofikwest merged commit ac54500 into main May 2, 2026
11 checks passed
@tofikwest tofikwest deleted the fix/pentest-create-notification-payload branch May 2, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant