Move integration settings into detail page#2746
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
3 issues found across 10 files
Confidence score: 3/5
- There is a concrete user-facing behavior risk in
apps/app/src/components/integrations/ConnectionVariablesForm.tsx: empty numeric inputs being coerced to0can overwrite intended blank state and lead to incorrect form values. - The same file also has a likely binding bug where not using nullish coalescing can render numeric
0as empty, creating confusion and potential data-entry regressions; severity/confidence here justify a moderate-risk score. apps/app/src/components/integrations/ConnectionVariableMultiSelect.tsxhas a lower-severity accessibility gap (icon-only remove button lacks an accessible name), which is important but not likely merge-blocking for core functionality.- Pay close attention to
apps/app/src/components/integrations/ConnectionVariablesForm.tsxandapps/app/src/components/integrations/ConnectionVariableMultiSelect.tsx- numeric input state handling may regress form behavior, and the remove control needs a screen-reader label.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/app/src/components/integrations/ConnectionVariablesForm.tsx">
<violation number="1" location="apps/app/src/components/integrations/ConnectionVariablesForm.tsx:159">
P2: Use nullish coalescing for input value binding so numeric `0` is preserved instead of rendered as empty.</violation>
<violation number="2" location="apps/app/src/components/integrations/ConnectionVariablesForm.tsx:220">
P2: Avoid coercing an empty numeric input to `0`; keep it empty until a real number is entered.</violation>
</file>
<file name="apps/app/src/components/integrations/ConnectionVariableMultiSelect.tsx">
<violation number="1" location="apps/app/src/components/integrations/ConnectionVariableMultiSelect.tsx:134">
P2: Provide an accessible name (e.g., aria-label) for the icon-only remove button so screen readers can announce what the control does.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
Contributor
|
🎉 This PR is included in version 3.43.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Summary by cubic
Moved integration account settings into the provider detail page and unified variable inputs with shared components. This consolidates OAuth flows and settings, shows mapped evidence tasks, and improves task integration suggestions.
New Features
Refactors
ConnectionVariablesFormandConnectionVariableMultiSelect(value normalization, empty input preserved, target repo validation).ManageIntegrationDialogto use the detail page for manage flows.Written for commit f3c5d57. Summary will update on new commits.