Skip to content

Move integration settings into detail page#2746

Merged
tofikwest merged 2 commits intomainfrom
fix/integration-detail-settings
May 4, 2026
Merged

Move integration settings into detail page#2746
tofikwest merged 2 commits intomainfrom
fix/integration-detail-settings

Conversation

@tofikwest
Copy link
Copy Markdown
Contributor

@tofikwest tofikwest commented May 4, 2026

Summary

  • move dynamic integration variable fields into shared components used by the integration detail settings sheet
  • route old integrations-page settings/configure actions and OAuth return flows to the detail settings sheet
  • show mapped evidence tasks on the integration detail page
  • add search and pagination to task integration suggestions

Validation

  • targeted ESLint passed for touched files
  • app/API build: user confirmed locally

Summary by cubic

Moved integration account settings into the provider detail page and unified variable inputs with shared components. This consolidates OAuth flows and settings, shows mapped evidence tasks, and improves task integration suggestions.

  • New Features

    • Settings now open in the provider detail sheet; old settings/configure actions and OAuth returns route here.
    • Mapped evidence tasks are shown on the integration detail page.
    • Task integration suggestions support search and pagination.
  • Refactors

    • Introduced shared variable fields via ConnectionVariablesForm and ConnectionVariableMultiSelect (value normalization, empty input preserved, target repo validation).
    • Replaced bespoke OAuth variable forms with shared fields.
    • Simplified integrations list and ManageIntegrationDialog to use the detail page for manage flows.

Written for commit f3c5d57. Summary will update on new commits.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment May 4, 2026 6:54pm
comp-framework-editor Ready Ready Preview, Comment May 4, 2026 6:54pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped May 4, 2026 6:54pm

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 10 files

Confidence score: 3/5

  • There is a concrete user-facing behavior risk in apps/app/src/components/integrations/ConnectionVariablesForm.tsx: empty numeric inputs being coerced to 0 can overwrite intended blank state and lead to incorrect form values.
  • The same file also has a likely binding bug where not using nullish coalescing can render numeric 0 as empty, creating confusion and potential data-entry regressions; severity/confidence here justify a moderate-risk score.
  • apps/app/src/components/integrations/ConnectionVariableMultiSelect.tsx has a lower-severity accessibility gap (icon-only remove button lacks an accessible name), which is important but not likely merge-blocking for core functionality.
  • Pay close attention to apps/app/src/components/integrations/ConnectionVariablesForm.tsx and apps/app/src/components/integrations/ConnectionVariableMultiSelect.tsx - numeric input state handling may regress form behavior, and the remove control needs a screen-reader label.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/app/src/components/integrations/ConnectionVariablesForm.tsx">

<violation number="1" location="apps/app/src/components/integrations/ConnectionVariablesForm.tsx:159">
P2: Use nullish coalescing for input value binding so numeric `0` is preserved instead of rendered as empty.</violation>

<violation number="2" location="apps/app/src/components/integrations/ConnectionVariablesForm.tsx:220">
P2: Avoid coercing an empty numeric input to `0`; keep it empty until a real number is entered.</violation>
</file>

<file name="apps/app/src/components/integrations/ConnectionVariableMultiSelect.tsx">

<violation number="1" location="apps/app/src/components/integrations/ConnectionVariableMultiSelect.tsx:134">
P2: Provide an accessible name (e.g., aria-label) for the icon-only remove button so screen readers can announce what the control does.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread apps/app/src/components/integrations/ConnectionVariablesForm.tsx Outdated
Comment thread apps/app/src/components/integrations/ConnectionVariablesForm.tsx Outdated
@vercel vercel Bot temporarily deployed to Preview – portal May 4, 2026 18:50 Inactive
@tofikwest tofikwest merged commit 7bbc643 into main May 4, 2026
11 checks passed
@tofikwest tofikwest deleted the fix/integration-detail-settings branch May 4, 2026 18:55
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants