Skip to content

[dev] [Marfuen] mariano/fix-trust-framework-toggle#2753

Merged
Marfuen merged 2 commits intomainfrom
mariano/fix-trust-framework-toggle
May 5, 2026
Merged

[dev] [Marfuen] mariano/fix-trust-framework-toggle#2753
Marfuen merged 2 commits intomainfrom
mariano/fix-trust-framework-toggle

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 5, 2026

This is an automated pull request to merge mariano/fix-trust-framework-toggle into dev.
It was created by the [Auto Pull Request] action.


Summary by cubic

Surfaced real error messages for Trust Portal compliance framework toggles to make failures actionable. We now log errors and include the message in toast descriptions; UI behavior is unchanged.

  • Bug Fixes

    • Updated all onToggle/onStatusChange handlers to console.error the failure and show error.message in toast descriptions instead of generic messages.
    • Kept optimistic updates with rollback on failure.
  • Refactors

    • Reordered imports and cleaned up formatting in TrustPortalSwitch.tsx; no runtime impact.

Written for commit 066a68b. Summary will update on new commits.

The 20 framework onToggle/onStatusChange handlers were swallowing the
caught error and showing a generic "Failed to update X status" toast,
making it impossible to tell whether the underlying call failed on
permission, validation, network, or DB error.

Log the error to console and pass error.message into the toast
description so the actual cause surfaces to the operator. No behavior
change beyond observability.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment May 5, 2026 4:45pm
comp-framework-editor Ready Ready Preview, Comment May 5, 2026 4:45pm
portal Ready Ready Preview, Comment May 5, 2026 4:45pm

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@Marfuen Marfuen merged commit b80bcf0 into main May 5, 2026
9 of 11 checks passed
@Marfuen Marfuen deleted the mariano/fix-trust-framework-toggle branch May 5, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant