Conversation
P1: Add metadata.set('policies', true) after policy fan-out so the
tracker boolean flag is set.
P1: Log batchTriggerAndWait failures in vendor/risk mitigation fan-outs
instead of silently ignoring them.
P2: Strip {{#if}}/{{/if}} markers from mixed-content nodes so template
syntax doesn't leak into rendered policies.
P2: Fix stale onboardingTriggerJobId locking publish button in
ToDoOverview.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The global regex flag in stripMarkerText would remove ALL matching
{{#if}}/{{/if}} markers in a subtree, corrupting boundaries of nested
conditional blocks. Removed the g flag so only the first occurrence
(the one that triggered the match) is stripped.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Covers placeholder replacement, inline/multi-node/nested conditionals, mixed content nodes, edge cases, buildVariables, buildFlags, processTemplate. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When an org has no vendors or risks, `total > 0 && completed >= total` evaluates to false, causing those steps to appear stuck forever. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Revert zero-item guard (total === 0 ||) back to (total > 0 &&) — before totals metadata is set, the default of 0 caused steps to appear complete then flip back to in-progress once actual totals arrived. Also add missing risksTotal/risksInfo metadata alongside vendorsTotal so risk mitigation progress tracks correctly in the UI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…on steps Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
A hung AI Gateway request was blocking the entire linkage step indefinitely. The fallback in run-linkage.ts already handles rerank failures gracefully (falls back to cosine ordering). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Don't render "Assessing Vendors"/"Assessing Risks" steps until their prerequisite creation step completes. Prevents the step from flashing as complete before totals metadata arrives. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 3.45.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to merge mariano/cubic-fixes into dev.
It was created by the [Auto Pull Request] action.
Summary by cubic
Fixes onboarding tracker accuracy and UX by hiding mitigation steps until creation is done and showing created/total counts. Adds risk totals metadata and a 30s reranker timeout to prevent linkage hangs.
risksTotalandrisksInfoduring org onboarding so risk mitigation progress renders correctly.Written for commit 23b5c07. Summary will update on new commits.