CS-365 [Feature] - Add ability to edit/delete findings from admin dashboard#2833
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
chasprowebdev
changed the title
Contributor
|
Recording: edit-delete-finding.mov |
…it-delete-finding-in-admin
Contributor
|
@cubic-dev-ai please review it. |
Contributor
@chasprowebdev I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 6 files
Confidence score: 3/5
- There is a concrete user-facing behavior risk in
apps/app/src/app/(app)/[orgId]/admin/organizations/[adminOrgId]/components/FindingsTab.tsx:AlertDialogActioncan close the confirmation immediately, even before the async delete state is set. - If the delete API fails, the dialog may already be dismissed, which hurts retry flow and can make failure handling feel broken for admins.
- This lands at moderate merge risk because the issue is reproducible and high-confidence (5/10 severity, 8/10 confidence), but it appears scoped to one interaction path rather than broadly destabilizing the PR.
- Pay close attention to
apps/app/src/app/(app)/[orgId]/admin/organizations/[adminOrgId]/components/FindingsTab.tsx- ensure the dialog stays open during async delete/failure so users can retry.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/app/src/app/(app)/[orgId]/admin/organizations/[adminOrgId]/components/FindingsTab.tsx">
<violation number="1" location="apps/app/src/app/(app)/[orgId]/admin/organizations/[adminOrgId]/components/FindingsTab.tsx:201">
P2: `AlertDialogAction` auto-closes on click, so this async delete flow can close the dialog before `deleting` is set. If the API call fails, the confirmation closes anyway instead of staying open for retry.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
Contributor
|
@cubic-dev-ai please review this. |
Contributor
@chasprowebdev I have started the AI code review. It will take a few minutes to complete. |
Contributor
|
🎉 This PR is included in version 3.58.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to merge chas/edit-delete-finding-in-admin into dev.
It was created by the [Auto Pull Request] action.
Summary by cubic
Adds edit and delete controls to findings in the admin orgs dashboard. Implements CS-365 with an admin delete API, an edit sheet for content/status/severity, and a delete flow that keeps the confirm dialog open until the request succeeds.
New Features
DELETE /v1/admin/organizations/:orgId/findings/:findingIdfor platform admins;findings.service.deleteacceptsmemberId: null; test added for admin delete.Refactors
AdminFindingRowand edit UI toEditFindingSheet; simplifiedFindingsTaband wired edit/delete flows.Written for commit 93b28be. Summary will update on new commits. Review in cubic