fix(people): address fifth round of cubic review findings#2893
Merged
Conversation
- guard sync errors in revokeAllVendorAccess and undoVendorRevocation - remove unused TodosOverview component (dead code) - batch attachment queries in getMemberChecklist (N+1 → 1 query) - extract fileToBase64 into shared lib/file-utils.ts Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 6 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Linked issue analysis
Linked issue: CS-312: [Feature] Add personnel Employment events date tracking + supporting evidence upload section
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Offboarding checklist loads evidence (batched query + presigned download URLs) | The service now performs a single attachment.findMany for all completion IDs, groups attachments by completion, and maps attachments to evidence objects including a presigned download URL. |
| ✅ | Uploading evidence via client hooks still works (fileToBase64 extracted to shared utility) | fileToBase64 was extracted into a shared lib and the hooks import it instead of duplicating logic, preserving upload behavior. |
claudfuen
pushed a commit
that referenced
this pull request
May 21, 2026
# [3.60.0](v3.59.2...v3.60.0) (2026-05-21) ### Bug Fixes * **cloud-tests:** show meaningful Auto-Remediate diff for configure-only plans ([90c95f6](90c95f6)) * **evidence-export:** load automations one at a time to prevent OOM ([07f02e4](07f02e4)) * **people:** address cubic review findings for offboarding feature ([#2884](#2884)) ([9d43a6b](9d43a6b)) * **people:** address fifth round of cubic review findings ([#2893](#2893)) ([dbc364c](dbc364c)) * **people:** address fourth round of cubic review findings ([#2892](#2892)) ([ca9d9a5](ca9d9a5)) * **people:** address remaining cubic review findings for offboarding ([#2890](#2890)) ([8026352](8026352)) * **people:** address third round of cubic review findings ([#2891](#2891)) ([8ec5214](8ec5214)) * **people:** ds component compatibility fixes for offboarding UI ([200b112](200b112)) * **ui:** close MultipleSelector dropdown on blur so it stops blocking sibling form controls ([b9d08c8](b9d08c8)) ### Features * **api:** unblock cloud-tests mutations for API key + service token callers ([26e53da](26e53da)) * **cloud-tests:** add deterministic AWS plan normalizer for SLR params ([e0ec0f7](e0ec0f7)) * **cloud-tests:** fail fast on missing required AWS command params ([5f2d342](5f2d342)) * **cloud-tests:** universal AI step-repair on AWS validation errors ([8adf505](8adf505)) * **frameworks:** show controls as default tab with requirement column ([e41365d](e41365d)) * **people:** add employment events tracking and offboarding checklist ([5e15a73](5e15a73))
Contributor
|
🎉 This PR is included in version 3.60.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes remaining Cubic findings from #2878 (fifth review pass):
revokeAllVendorAccessandundoVendorRevocationwith try/catch + logger.warn (matches existing pattern inrevokeVendorAccess)TodosOverviewcomponent (dead code, never imported)getMemberChecklist— N+1 → single query + groupByfileToBase64into sharedlib/file-utils.ts, deduplicate from hooksTest plan
🤖 Generated with Claude Code
Summary by cubic
Hardens offboarding flows and speeds up checklist evidence loading by batching attachment queries and guarding sync errors. Supports CS-312 by making employment event evidence upload and review more reliable.
Bug Fixes
logger.warninstead of failing the action.Refactors
getMemberChecklistand pre-sign download URLs once to remove N+1 queries and improve evidence load time.fileToBase64intoapps/app/src/lib/file-utils.tsand reuse in relevant hooks for uploads.TodosOverviewcomponent.Written for commit b58e358. Summary will update on new commits. Review in cubic