fix(people): fix offboarding test spec missing mocks#2895
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
- add member, attachment, $transaction mocks to mockDb - add getPresignedDownloadUrl mock to attachmentsService - mock db.attachment.findMany for batched checklist/revocation queries - add member.findFirst mock to revokeVendorAccess tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Marfuen
force-pushed
the
mariano/cs-312-cubic-review-fixes-7
branch
from
1bd6d4c to
df71b65
Compare
Contributor
Author
|
@cubic-dev-ai re-review this |
Contributor
@Marfuen I have started the AI code review. It will take a few minutes to complete. |
Contributor
|
🎉 This PR is included in version 3.60.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes P0 test spec failures — missing mocks caused TypeErrors at runtime:
member,attachment,$transactionmocks tomockDbgetPresignedDownloadUrlmock tomockAttachmentsServicedb.attachment.findManyfor batched checklist/revocation queriesmember.findFirstmock to allrevokeVendorAccesstest casescount/createManyto revocation mock forrevokeAllVendorAccessAll 21 tests pass.
Test plan
npx jest src/offboarding-checklist/offboarding-checklist.service.spec.ts— 21/21 pass🤖 Generated with Claude Code
Summary by cubic
Fixes failing offboarding checklist tests by adding missing mocks in
@dband the attachments service, and adds cursor-based batching togetAutomationHeadersto avoid heavy evidence queries. This stabilizes CS-312 offboarding/evidence flows, and all 21 specs now pass.Written for commit df71b65. Summary will update on new commits. Review in cubic