fix(cloud-tests): harden aws validation paths#2905
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
🎉 This PR is included in version 3.62.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Notes
Summary by cubic
Hardened AWS validation and IAM MFA scanning to prevent false negatives and keep scans running. Correctly validates
RevokeSecurityGroupIngressCommandinputs and continues MFA checks when console-access probes fail unexpectedly.RevokeSecurityGroupIngressCommand: RequireGroupIdorGroupNameonly for property-based revokes; allow rule-ID-only revokes without a group.SecurityGroupRuleIdsno longer satisfy the group requirement when rule properties are present. Updated error messages.GetLoginProfilethrows non-NoSuchEntityerrors (e.g.,AccessDeniedException), continue MFA checks and treat console access as present to avoid suppressing findings.CreateBucket: Safer bucket name normalization (coerce string/number, lower-case, replace underscores).Written for commit 5a79bcb. Summary will update on new commits. Review in cubic