Skip to content

fix(cloud-tests): backfill egress security group ids#2908

Merged
tofikwest merged 1 commit into
mainfrom
tofik/fix-egress-groupid-normalizer
May 22, 2026
Merged

fix(cloud-tests): backfill egress security group ids#2908
tofikwest merged 1 commit into
mainfrom
tofik/fix-egress-groupid-normalizer

Conversation

@tofikwest
Copy link
Copy Markdown
Contributor

@tofikwest tofikwest commented May 22, 2026

Summary

  • include EC2 security-group egress authorize/revoke commands in GroupId backfill
  • add regression coverage for egress fix and rollback steps

Verification

  • bunx jest src/cloud-security/plan-normalizer-aws-edge-cases.spec.ts src/cloud-security/plan-normalizer.spec.ts --passWithNoTests
  • bunx eslint src/cloud-security/plan-normalizer.ts src/cloud-security/plan-normalizer-aws-edge-cases.spec.ts
  • bunx prettier --check apps/api/src/cloud-security/plan-normalizer.ts apps/api/src/cloud-security/plan-normalizer-aws-edge-cases.spec.ts
  • git diff --check

Notes: broader API typecheck still fails on existing unrelated baseline errors (AI SDK v3/v2 type mismatch, better-auth duplicate package type mismatch, stale specs). Broad src/cloud-security Jest run passed 24 suites, then remediation.controller.spec.ts stopped on the local non-TLS Postgres guard.


Summary by cubic

Fixes missing GroupId backfill for EC2 security-group egress steps in normalizeFixPlan. Adds regression tests to cover egress authorize/revoke and rollback paths.

  • Bug Fixes
    • Include AuthorizeSecurityGroupEgressCommand and RevokeSecurityGroupEgressCommand in the backfill set, deriving GroupId from the finding resourceId.
    • Add edge-case tests to verify GroupId is set on egress fix and rollback steps.

Written for commit 816ba5c. Summary will update on new commits. Review in cubic

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comp-framework-editor Ready Ready Preview, Comment May 22, 2026 1:36am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
app Skipped Skipped May 22, 2026 1:36am
portal Skipped Skipped May 22, 2026 1:36am

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@tofikwest tofikwest merged commit 10bcf72 into main May 22, 2026
11 checks passed
@tofikwest tofikwest deleted the tofik/fix-egress-groupid-normalizer branch May 22, 2026 01:42
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.62.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants