fix(cloud-tests): backfill egress security group ids#2908
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
🎉 This PR is included in version 3.62.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Notes: broader API typecheck still fails on existing unrelated baseline errors (AI SDK v3/v2 type mismatch, better-auth duplicate package type mismatch, stale specs). Broad src/cloud-security Jest run passed 24 suites, then remediation.controller.spec.ts stopped on the local non-TLS Postgres guard.
Summary by cubic
Fixes missing
GroupIdbackfill for EC2 security-group egress steps innormalizeFixPlan. Adds regression tests to cover egress authorize/revoke and rollback paths.AuthorizeSecurityGroupEgressCommandandRevokeSecurityGroupEgressCommandin the backfill set, derivingGroupIdfrom the findingresourceId.GroupIdis set on egress fix and rollback steps.Written for commit 816ba5c. Summary will update on new commits. Review in cubic