Skip to content

fix(trust): keep portal branding after save#2911

Merged
tofikwest merged 1 commit into
mainfrom
tofik/fix-trust-portal-branding
May 22, 2026
Merged

fix(trust): keep portal branding after save#2911
tofikwest merged 1 commit into
mainfrom
tofik/fix-trust-portal-branding

Conversation

@tofikwest
Copy link
Copy Markdown
Contributor

@tofikwest tofikwest commented May 22, 2026

Summary

  • keep trust portal favicon and brand color state in a dedicated branding settings component so saved values do not fall back to initial server props when the tab remounts
  • refresh trust portal server settings after successful favicon upload/removal or brand color save
  • validate brand colors before saving, while still allowing empty brand color to persist as a reset to default branding
  • preserve the current portal enabled state during brand color updates
  • move trust portal certificate icons off lucide to the design-system icon set while touching the switch component

Verification

  • bunx vitest run 'src/app/(app)/[orgId]/trust/portal-settings/components' — 74 passed
  • bunx vitest run 'src/app/(app)/[orgId]/trust/portal-settings/components/BrandSettings.test.tsx' 'src/app/(app)/[orgId]/trust/portal-settings/components/UpdateTrustFavicon.test.tsx' 'src/app/(app)/[orgId]/trust/portal-settings/components/TrustPortalBrandingSettings.test.tsx' 'src/app/(app)/[orgId]/trust/portal-settings/components/TrustPortalSwitch.test.tsx' — 21 passed
  • git diff --check

Note

  • bunx turbo run typecheck --filter=@trycompai/app still fails on existing unrelated app errors, including cloud-tests provider test fixtures, AI SDK v2/v3 type mismatches, missing invitations route test module, and Better Auth duplicate type resolution. No remaining errors reference the trust portal branding files.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment May 22, 2026 2:09pm
comp-framework-editor Ready Ready Preview, Comment May 22, 2026 2:09pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped May 22, 2026 2:09pm

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@tofikwest tofikwest merged commit a201fab into main May 22, 2026
11 checks passed
@tofikwest tofikwest deleted the tofik/fix-trust-portal-branding branch May 22, 2026 14:14
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.63.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants