Skip to content

[comp] Production Deploy#2954

Merged
tofikwest merged 4 commits into
releasefrom
main
May 28, 2026
Merged

[comp] Production Deploy#2954
tofikwest merged 4 commits into
releasefrom
main

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 28, 2026

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.


Summary by cubic

Promotes the latest MCP Server release to production. Adds multipart policy PDF upload, built‑in role obligations APIs/tools, expanded finding frameworks, and updates docs/SDK.

  • New Features

    • Multipart policy PDF upload at /v1/policies/{id}/pdf (multipart or base64). UI-only; use presigned /pdf/upload-url + /pdf/confirm for clients.
    • Built-in roles obligations: get and update endpoints with MCP tools (get-built-in-obligations, update-built-in-obligations).
    • Added finding types: PCI DSS, HIPAA, GDPR, ISO 9001, ISO 42001.
  • Refactors

    • Policy PDF delete now targets a version; defaults to latest draft; blocked for published or pending versions.
    • Clarified auth attribution for cloud security actions (session, API key, service token).
    • Added optional organizationId across several DTOs (auto-resolved/ignored by server).
    • Updated README and landing page to link the mcp-server.mcpb GitHub release.
    • Added repository metadata and package-lock.json; regenerated SDK with base error CompAiError; updated OpenAPI/manifest/tool names; removed stale generator lock.

Written for commit e43721a. Summary will update on new commits.

Review in cubic

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app (staging) Ready Ready Preview, Comment May 28, 2026 8:06pm
comp-framework-editor (staging) Ready Ready Preview, Comment May 28, 2026 8:06pm
portal (staging) Ready Ready Preview, Comment May 28, 2026 8:06pm

Request Review

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ tofikwest
❌ speakeasy-github[bot]
❌ speakeasybot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 44 files

Confidence score: 1/5

  • There is a likely merge-blocking regression in apps/mcp-server/src/funcs/policiesPoliciesControllerUploadPolicyPdfV1Multipart.ts: new FormData() is sent without appending fields from payload$, so upload requests can be transmitted with an empty body.
  • Given the reported severity (10/10) and high confidence (9/10), this is a concrete functional break in a user-facing flow rather than a minor implementation detail.
  • Pay close attention to apps/mcp-server/src/funcs/policiesPoliciesControllerUploadPolicyPdfV1Multipart.ts - ensure multipart fields from the parsed payload are appended before sending the request.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/mcp-server/src/funcs/policiesPoliciesControllerUploadPolicyPdfV1Multipart.ts">

<violation number="1" location="apps/mcp-server/src/funcs/policiesPoliciesControllerUploadPolicyPdfV1Multipart.ts:90">
P0: FormData is created empty but never populated with fields from the request payload. The function creates `new FormData()` on line 77 and sends it as the request body, but the parsed request payload (`payload$`) containing the file, fileName, versionId, etc. is never appended as form fields. Every upload will send an empty body and fail to upload the PDF.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

return [parsed$, { status: "invalid" }];
}
const payload$ = parsed$.value;
const body$ = new FormData();
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0: FormData is created empty but never populated with fields from the request payload. The function creates new FormData() on line 77 and sends it as the request body, but the parsed request payload (payload$) containing the file, fileName, versionId, etc. is never appended as form fields. Every upload will send an empty body and fail to upload the PDF.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/mcp-server/src/funcs/policiesPoliciesControllerUploadPolicyPdfV1Multipart.ts, line 90:

<comment>FormData is created empty but never populated with fields from the request payload. The function creates `new FormData()` on line 77 and sends it as the request body, but the parsed request payload (`payload$`) containing the file, fileName, versionId, etc. is never appended as form fields. Every upload will send an empty body and fail to upload the PDF.</comment>

<file context>
@@ -0,0 +1,162 @@
+    return [parsed$, { status: "invalid" }];
+  }
+  const payload$ = parsed$.value;
+  const body$ = new FormData();
+
+  const pathParams$ = {
</file context>
Fix with Cubic

@tofikwest tofikwest merged commit a6b99d5 into release May 28, 2026
13 of 14 checks passed
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.66.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants