Skip to content

fix(app): fit requirements table columns#2979

Merged
tofikwest merged 1 commit into
mainfrom
tofik/requirements-table-overflow
May 30, 2026
Merged

fix(app): fit requirements table columns#2979
tofikwest merged 1 commit into
mainfrom
tofik/requirements-table-overflow

Conversation

@tofikwest
Copy link
Copy Markdown
Contributor

@tofikwest tofikwest commented May 30, 2026

Summary

  • Fix CS-267 by moving requirements tables to a shared fixed-layout column model so all nine columns fit the viewport instead of expanding to content width.
  • Reuse the same column group/header in grouped and ungrouped requirement views, shorten the Documents header to Docs, and remove fixed text max-widths that pushed the table wider.
  • Add focused coverage for the shared requirements table layout.

Verification

  • bunx vitest run "src/app/(app)/[orgId]/frameworks/[frameworkInstanceId]/components/requirements-table-layout.test.tsx" "src/app/(app)/[orgId]/frameworks/[frameworkInstanceId]/components/family-expansion-state.test.ts"
  • rg -n "@trycompai/ui|lucide-react" touched requirement table files
  • git diff --check
  • bunx turbo run typecheck --filter=@trycompai/app currently fails on existing baseline errors outside this change; no touched files appear in the failures.

Summary by cubic

Fixes CS-267 by switching requirements tables to a shared fixed-layout column model so all nine columns fit the viewport in both grouped and ungrouped views. Shortens the Documents header to Docs and removes width constraints that caused overflow.

  • Bug Fixes
    • Introduced a shared layout component with fixed table layout and colgroup widths.
    • Applied the shared header/columns to both FrameworkRequirements and FrameworkRequirementsGrouped.
    • Shortened “Documents” to “Docs” (with title tooltip) and removed per-cell max-widths for consistent truncation.
    • Added tests to lock column count, header labels, and fixed table layout behavior.

Written for commit 318330e. Summary will update on new commits.

Review in cubic

@linear
Copy link
Copy Markdown

linear Bot commented May 30, 2026

CS-267

@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment May 30, 2026 8:47pm
comp-framework-editor Ready Ready Preview, Comment May 30, 2026 8:47pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped May 30, 2026 8:47pm

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@tofikwest tofikwest merged commit b1315a0 into main May 30, 2026
11 checks passed
@tofikwest tofikwest deleted the tofik/requirements-table-overflow branch May 30, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant