Skip to content

[comp] Production Deploy#3023

Merged
tofikwest merged 26 commits into
releasefrom
main
Jun 4, 2026
Merged

[comp] Production Deploy#3023
tofikwest merged 26 commits into
releasefrom
main

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Jun 4, 2026

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.


Summary by cubic

Add support for custom department names across Policies, Tasks, Risks, and People. Converts enum-based departments to strings, with validation and a new UI picker. Addresses CS-206.

  • New Features

    • Departments are now free‑form strings (trimmed, max 64 chars); built‑ins like "none", "it", "hr" still work.
    • New DepartmentSelect with “Add custom…” flow; used in People, Policy update, Task create/edit, and Risk forms.
    • API updates: DTOs accept strings; Tasks normalize/validate department; Risks filter by custom departments; Swagger updated.
    • Visibility logic, embeddings, and link suggestions now use string departments.
  • Migration

    • DB: convert department and visibleToDepartments from enum to TEXT for Policy, Member, Risk, Task; keep 'none' defaults where used.
    • No data loss expected; clients relying on enum types should treat departments as strings.

Written for commit ec2c709. Summary will update on new commits.

Review in cubic

chasprowebdev and others added 26 commits June 2, 2026 14:22
CS-206 [Improvement] - Ability to be able to add Custom departments to be assigned for Policies, Evidence and People
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app (staging) Ready Ready Preview, Comment Jun 4, 2026 3:01pm
comp-framework-editor (staging) Ready Ready Preview, Comment Jun 4, 2026 3:01pm
portal (staging) Ready Ready Preview, Comment Jun 4, 2026 3:01pm

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found

Confidence score: 4/5

  • This PR is likely safe to merge, with minimal risk: the main issue is a contract mismatch rather than a runtime failure.
  • In apps/api/src/tasks/tasks.controller.ts, updateTask allows department: null at runtime while OpenAPI still marks department as a non-nullable string, which can mislead API consumers and generated clients.
  • Given the moderate-low severity (4/10), impact appears limited to API documentation/schema expectations instead of core task update behavior.
  • Pay close attention to apps/api/src/tasks/tasks.controller.ts - align OpenAPI nullability with actual updateTask runtime handling.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/api/src/tasks/tasks.controller.ts">

<violation number="1" location="apps/api/src/tasks/tasks.controller.ts:895">
P2: `updateTask` accepts `department: null` at runtime, but the OpenAPI request schema still documents department as non-nullable string.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

frequency?: string;
integrationScheduleFrequency?: string;
department?: string;
department?: string | null;
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: updateTask accepts department: null at runtime, but the OpenAPI request schema still documents department as non-nullable string.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/api/src/tasks/tasks.controller.ts, line 895:

<comment>`updateTask` accepts `department: null` at runtime, but the OpenAPI request schema still documents department as non-nullable string.</comment>

<file context>
@@ -858,7 +892,7 @@ export class TasksController {
       frequency?: string;
       integrationScheduleFrequency?: string;
-      department?: string;
+      department?: string | null;
       reviewDate?: string;
       notRelevantJustification?: string;
</file context>
Fix with cubic

@tofikwest tofikwest merged commit b734816 into release Jun 4, 2026
13 checks passed
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.70.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants