Skip to content

Claudio/comp 105 simplify people management#466

Merged
claudfuen merged 2 commits intomainfrom
claudio/comp-105-simplify-people-management
Apr 29, 2025
Merged

Claudio/comp 105 simplify people management#466
claudfuen merged 2 commits intomainfrom
claudio/comp-105-simplify-people-management

Conversation

@claudfuen
Copy link
Copy Markdown
Contributor

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes COMP-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

- Changed all references from "employees" to "people" in routes and API endpoints for consistency.
- Updated revalidation paths in invite and remove employee actions to reflect the new naming convention.
- Removed deprecated employee layout and page components, replacing them with new people-related components.
- Adjusted localization files to reflect the terminology change from employees to people.
- Enhanced the UI components to align with the new structure, ensuring a cohesive user experience.
Copilot AI review requested due to automatic review settings April 29, 2025 16:12
@linear
Copy link
Copy Markdown

linear bot commented Apr 29, 2025

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
app ⬜️ Skipped (Inspect) Apr 29, 2025 4:12pm
comp-portal ⬜️ Skipped (Inspect) Apr 29, 2025 4:12pm

@claudfuen claudfuen merged commit 6436aa5 into main Apr 29, 2025
7 checks passed
@claudfuen claudfuen deleted the claudio/comp-105-simplify-people-management branch April 29, 2025 16:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies people management by renaming URL endpoints and UI components from "employees" to "people" while removing redundant employee-specific pages and components. Key changes include:

  • Updating revalidation paths and UI breadcrumbs to use the "people" nomenclature.
  • Disabling an email input field in employee details.
  • Removing legacy employee list pages and components.

Reviewed Changes

Copilot reviewed 51 out of 51 changed files in this pull request and generated no comments.

Show a summary per file
File Description
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/people/[employeeId]/layout.tsx Introduces a new layout for "people" with updated breadcrumbs.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/people/[employeeId]/components/EmployeeDetails.tsx Disables the email input field.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/people/[employeeId]/actions/update-employee.ts Updates revalidation paths from employees to people.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/people/[employeeId]/actions/update-employee-status.ts Updates revalidation paths from employees to people.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/people/[employeeId]/actions/update-employee-details.ts Updates revalidation paths from employees to people.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/people/[employeeId]/actions/update-department.ts Updates revalidation paths from employees to people.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/implementation/page.tsx Adjusts URL and documentation links to match the "people" naming.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/employees/all/* Removes legacy employee list pages and components.
apps/app/src/actions/organization/remove-employee.ts Updates revalidation paths from employees/all to people/all.
apps/app/src/actions/organization/invite-employee.ts Updates revalidation paths from employees/all to people/all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants