Claudio/comp 105 simplify people management#466
Merged
Conversation
- Changed all references from "employees" to "people" in routes and API endpoints for consistency. - Updated revalidation paths in invite and remove employee actions to reflect the new naming convention. - Removed deprecated employee layout and page components, replacing them with new people-related components. - Adjusted localization files to reflect the terminology change from employees to people. - Enhanced the UI components to align with the new structure, ensuring a cohesive user experience.
…/comp-105-simplify-people-management
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies people management by renaming URL endpoints and UI components from "employees" to "people" while removing redundant employee-specific pages and components. Key changes include:
- Updating revalidation paths and UI breadcrumbs to use the "people" nomenclature.
- Disabling an email input field in employee details.
- Removing legacy employee list pages and components.
Reviewed Changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/people/[employeeId]/layout.tsx | Introduces a new layout for "people" with updated breadcrumbs. |
| apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/people/[employeeId]/components/EmployeeDetails.tsx | Disables the email input field. |
| apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/people/[employeeId]/actions/update-employee.ts | Updates revalidation paths from employees to people. |
| apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/people/[employeeId]/actions/update-employee-status.ts | Updates revalidation paths from employees to people. |
| apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/people/[employeeId]/actions/update-employee-details.ts | Updates revalidation paths from employees to people. |
| apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/people/[employeeId]/actions/update-department.ts | Updates revalidation paths from employees to people. |
| apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/implementation/page.tsx | Adjusts URL and documentation links to match the "people" naming. |
| apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/employees/all/* | Removes legacy employee list pages and components. |
| apps/app/src/actions/organization/remove-employee.ts | Updates revalidation paths from employees/all to people/all. |
| apps/app/src/actions/organization/invite-employee.ts | Updates revalidation paths from employees/all to people/all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist