Skip to content

Add support for dynamic callback URL in Google sign-in flow #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marfuen merged 1 commit into from
Apr 29, 2025
Merged

Add support for dynamic callback URL in Google sign-in flow #481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/app/src/components/google-sign-in.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,11 @@ export function GoogleSignIn({
? `/api/auth/invitation?code=${inviteCode}`
: "/";

const callbackURL = new URL(redirectTo, window.location.origin);

await authClient.signIn.social({
provider: "google",
callbackURL: callbackURL.toString(),
Comment on lines +26 to +30
Copy link

Copilot AI Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider inlining the URL conversion if the variable is only used once (e.g., directly passing new URL(redirectTo, window.location.origin).toString() to authClient.signIn.social), or add a clarifying comment if keeping the variable improves readability.

Suggested change
const callbackURL = new URL(redirectTo, window.location.origin);
await authClient.signIn.social({
provider: "google",
callbackURL: callbackURL.toString(),
await authClient.signIn.social({
provider: "google",
callbackURL: new URL(redirectTo, window.location.origin).toString(),

Copilot uses AI. Check for mistakes.
});
};

Expand Down