Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes an early return block from the getArtifactsCreatedFromPolicy function to allow subsequent logic to execute even when no artifacts are found.
- Removed the artifacts query and its associated early return block.
- Continues with fetching mappedControls regardless of artifacts presence.
Comments suppressed due to low confidence (1)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/[policyId]/data/index.ts:18
- Ensure that removing the early return does not inadvertently affect later logic that might rely on artifacts being non-empty. If artifacts are no longer needed for downstream processing, consider removing any related code or updating documentation accordingly.
const artifacts = await db.artifact.findMany({
Contributor
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist