Skip to content

chore: dont return early#623

Merged
Marfuen merged 1 commit intomainfrom
mariano/comp-policy-control-fix
May 15, 2025
Merged

chore: dont return early#623
Marfuen merged 1 commit intomainfrom
mariano/comp-policy-control-fix

Conversation

@Marfuen
Copy link
Contributor

@Marfuen Marfuen commented May 15, 2025

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes COMP-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copilot AI review requested due to automatic review settings May 15, 2025 18:35
@vercel
Copy link

vercel bot commented May 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 15, 2025 6:35pm
comp-framework-editor 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 15, 2025 6:35pm
comp-trust 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 15, 2025 6:35pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
comp-portal ⬜️ Skipped (Inspect) May 15, 2025 6:35pm

@Marfuen Marfuen merged commit 961235b into main May 15, 2025
7 of 8 checks passed
@Marfuen Marfuen deleted the mariano/comp-policy-control-fix branch May 15, 2025 18:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an early return block from the getArtifactsCreatedFromPolicy function to allow subsequent logic to execute even when no artifacts are found.

  • Removed the artifacts query and its associated early return block.
  • Continues with fetching mappedControls regardless of artifacts presence.
Comments suppressed due to low confidence (1)

apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/[policyId]/data/index.ts:18

  • Ensure that removing the early return does not inadvertently affect later logic that might rely on artifacts being non-empty. If artifacts are no longer needed for downstream processing, consider removing any related code or updating documentation accordingly.
const artifacts = await db.artifact.findMany({

@claudfuen
Copy link
Contributor

🎉 This PR is included in version 1.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants