Fix alert colors for pending policy approval#695
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the styling of the pending approval alert in the PolicyOverview component by replacing manual red styling with the new "destructive" variant and corresponding CSS classes.
- Replaces manual "border-red-500 bg-red-50" styling with a variant property.
- Introduces tailored class names for light and dark modes.
Comments suppressed due to low confidence (1)
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/policies/[policyId]/components/PolicyOverview.tsx:109
- Confirm that the new 'variant="destructive"' prop provides complete and consistent alert styling and that any additional custom classes are necessary rather than duplicating or overriding styles defined by the variant.
<Alert variant="destructive" className="rounded-sm bg-destructive/10 dark:bg-destructive/20">
Contributor
Author
|
🎉 This PR is included in version 1.30.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
bun test(fails: The following filters did not match any test files)bun run test(fails: turbo: command not found)bun run format(fails: biome: command not found)