Revert "[dev] [Marfuen] mariano/comp-190-unable-to-edit-policy-name-or-description-after-creating"#841
Merged
Marfuen merged 1 commit intoJun 8, 2025
Conversation
…r-description-after-creating"
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Marfuen
deleted the
revert-839-mariano/comp-190-unable-to-edit-policy-name-or-description-after-creating
branch
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the changes introduced in PR #839, restoring the previous implementation of the policy editing and approval UI components. Key changes include reintroducing the removed components (UpdatePolicyOverview, PolicyOverviewHeader, SubmitApprovalDialog, etc.), reverting modifications in policy pages and dialogs, and restoring the original actions and schemas used for policy updates.
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| UpdatePolicyOverview.tsx | Reverts removal of the update policy overview component. |
| PolicyOverviewHeader.tsx | Reverts removal of the policy header component. |
| SubmitApprovalDialog.tsx | Reverts modifications in the submit approval dialog formatting and imports. |
| PolicyPage.tsx | Reverts changes to the PolicyPage structure and props handling. |
| PolicyOverviewSheet.tsx | Reintroduces the policy overview sheet component. |
| PolicyStatusAlerts.tsx | Reverts removal of the policy status alerts component. |
| PolicyPendingApprovalAlert.tsx | Reverts removal of the pending approval alert component. |
| PolicyOverview.tsx | Reverts re-implementation of the policy overview component. |
| PolicyDeleteDialog.tsx | Reverts changes in the policy delete dialog component. |
| PolicyControlMappings.tsx | Reverts modifications in control mapping actions and formatting. |
| PolicyControlMappingModal.tsx | Reverts updates in the control mapping modal implementation. |
| PolicyControlMappingConfirmDeleteModal.tsx | Reverts updates in the control mapping delete modal. |
| PolicyArchiveSheet.tsx | Reverts changes in the archive/restore sheet UI. |
| PolicyActionDialog.tsx | Reverts changes in the policy action dialog component. |
| Dialogs/PolicyActionDialogs.tsx | Reverts the composite policy action dialogs implementation. |
| Dialogs/PolicyActionDialog.tsx | Reverts the duplicate policy action dialog implementation. |
| actions/schema.ts | Reverts schema updates for policy overview, removing changes to name/description. |
| update-policy-overview-action.ts | Reverts changes including the type assertion for the new field. |
| update-policy-form-action.ts | Reverts removal of ‘name’ and ‘description’ fields from the update action. |
Comments suppressed due to low confidence (1)
apps/app/src/actions/schema.ts:285
- Verify that removing the 'name' and 'description' fields from updatePolicyFormSchema is intentional and aligns with the backend data handling expectations.
name: z.string(),
Comment on lines
+58
to
+61
| ? ({ | ||
| isRequiredToSign: | ||
| isRequiredToSign === "required", | ||
| } as any) |
There was a problem hiding this comment.
Consider refining the type assertion instead of using 'as any' so that the updated types are properly enforced without bypassing TypeScript checks.
Suggested change
| ? ({ | |
| isRequiredToSign: | |
| isRequiredToSign === "required", | |
| } as any) | |
| ? { | |
| isRequiredToSign: | |
| isRequiredToSign === "required", | |
| } |
Contributor
|
🎉 This PR is included in version 1.36.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #839