Fix DataSheetGrid row selection#842
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix the row selection behavior in DataSheetGrid by ensuring a stable and unique row key is provided.
- Added the rowKey property with the value "id" to enhance row selection stability.
- Consistent updates made in both TasksClientPage and ControlsClientPage.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/framework-editor/app/(pages)/tasks/TasksClientPage.tsx | Added rowKey="id" to DataSheetGrid for unique row identification |
| apps/framework-editor/app/(pages)/controls/ControlsClientPage.tsx | Added rowKey="id" to DataSheetGrid for consistent and stable row selection |
Comments suppressed due to low confidence (2)
apps/framework-editor/app/(pages)/tasks/TasksClientPage.tsx:298
- Verify that 'id' is a unique and stable key for each row to ensure reliable selection behavior in DataSheetGrid.
rowKey="id"
apps/framework-editor/app/(pages)/controls/ControlsClientPage.tsx:380
- Ensure that the 'id' property is consistently unique across rows to maintain proper row identification in the grid.
rowKey="id"
- add setDisplayedData function to manage displayed data state - improve grid change handling with displayedDataRef for better accuracy - streamline data processing during task creation, update, and deletion operations - enhance readability and maintainability with consistent formatting and comments
… data handling - add useEffect to synchronize displayed data with dataForDisplay - enhance useChangeTracking with displayedDataRef for better state management - improve code readability with consistent formatting and comments
Contributor
Author
|
🎉 This PR is included in version 1.36.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataSheetGriduses a stablerowKeyTesting
bun run lint(fails: Could not find@comp/ui#topoin root turbo.json or "topo" in package)https://chatgpt.com/codex/tasks/task_e_6845c146152c8320bd13e7a456c150af