Skip to content

[comp] Production Deploy #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claudfuen merged 5 commits into from
Jun 17, 2025
Merged

[comp] Production Deploy #944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c14c28
feat(tests): add layout, loading, and page components for cloud compl…
claudfuen Jun 17, 2025
deeefa3
refactor(loading): simplify loading component
claudfuen Jun 17, 2025
221106c
feat(metadata): add generateMetadata function for Controls, Tasks, an…
claudfuen Jun 17, 2025
58df150
Merge branch 'main' of https://github.com/trycompai/comp into claudio…
claudfuen Jun 17, 2025
c9cf5b5
Merge pull request #943 from trycompai/claudio/stripe
claudfuen Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/app/src/app/(app)/[orgId]/controls/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ interface ControlTableProps {
searchParams: Promise<SearchParams>;
}

export async function generateMetadata(): Promise<Metadata> {
return {
title: 'Controls',
};
}

export default async function ControlsPage({ ...props }: ControlTableProps) {
const searchParams = await props.searchParams;
const search = searchParamsCache.parse(searchParams);
Expand Down
58 changes: 2 additions & 56 deletions .../(app)/[orgId]/frameworks/[frameworkInstanceId]/requirements/[requirementKey]/loading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,57 +1,3 @@
import { Card, CardContent, CardHeader, CardTitle } from '@comp/ui/card';
import { Skeleton } from '@comp/ui/skeleton';
import { Table, TableBody, TableCell, TableHead, TableHeader, TableRow } from '@comp/ui/table';
import Loader from '@/components/ui/loader';

export default function Loading() {
return (
<div className="flex flex-col gap-6">
<Card>
<CardHeader>
<CardTitle className="flex items-center justify-between">
<div>
<Skeleton className="mb-2 h-4 w-24" />
<Skeleton className="h-8 w-64" />
</div>
</CardTitle>
</CardHeader>
<CardContent>
<Skeleton className="h-4 w-full" />
</CardContent>
</Card>

<Card>
<CardHeader>
<CardTitle>
<Skeleton className="h-6 w-48" />
</CardTitle>
</CardHeader>
<CardContent>
<Table>
<TableHeader>
<TableRow>
<TableHead>
<Skeleton className="h-4 w-[300px]" />
</TableHead>
<TableHead>
<Skeleton className="h-4 w-[200px]" />
</TableHead>
</TableRow>
</TableHeader>
<TableBody>
{[1, 2, 3].map((index) => (
<TableRow key={index}>
<TableCell>
<Skeleton className="h-4 w-[300px]" />
</TableCell>
<TableCell>
<Skeleton className="h-4 w-[200px]" />
</TableCell>
</TableRow>
))}
</TableBody>
</Table>
</CardContent>
</Card>
</div>
);
}
export default Loader;
7 changes: 7 additions & 0 deletions apps/app/src/app/(app)/[orgId]/tasks/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ import { headers } from 'next/headers';
import { TaskList } from './components/TaskList';
import PageCore from '@/components/pages/PageCore.tsx';
import PageWithBreadcrumb from '@/components/pages/PageWithBreadcrumb';
import { Metadata } from 'next';

export async function generateMetadata(): Promise<Metadata> {
return {
title: 'Tasks',
};
}

// Force dynamic rendering to ensure searchParams are always fresh
export const dynamic = 'force-dynamic';
Expand Down
7 changes: 7 additions & 0 deletions apps/app/src/app/(app)/[orgId]/tests/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export default async function Layout({ children }: { children: React.ReactNode }) {
return (
<div className="m-auto max-w-[1200px]">
<main>{children}</main>
</div>
);
}
0 ...app)/[orgId]/tests/(overview)/loading.tsx → ...p/src/app/(app)/[orgId]/tests/loading.tsx
View file
Open in desktop
File renamed without changes.
9 changes: 8 additions & 1 deletion ...p/(app)/[orgId]/tests/(overview)/page.tsx → .../app/src/app/(app)/[orgId]/tests/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ import { auth } from '@/utils/auth';
import { db } from '@comp/db';
import { headers } from 'next/headers';
import { redirect } from 'next/navigation';
import { Metadata } from 'next';

export async function generateMetadata(): Promise<Metadata> {
return {
title: 'Cloud Compliance',
};
}

export default async function CloudTests({ params }: { params: Promise<{ orgId: string }> }) {
const { orgId } = await params;
Expand All @@ -14,7 +21,7 @@ export default async function CloudTests({ params }: { params: Promise<{ orgId:
}

return (
<div className="m-auto max-w-[1200px]">
<div className="m-auto">
<AppOnboarding
title={'Cloud Compliance'}
description={
Expand Down
Loading