Skip to content

feat(agent): bound agent builder retries and improve chat scrolling - #89

Merged
ripgrim merged 3 commits into
mainfrom
rg/cmp-63-message-scroller
Aug 7, 2026
Merged

feat(agent): bound agent builder retries and improve chat scrolling#89
ripgrim merged 3 commits into
mainfrom
rg/cmp-63-message-scroller

Conversation

@ripgrim

@ripgrim ripgrim commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

Improve private agent chat scrolling and prevent agent-builder failures from turning into runaway retries.

  • Keeps streamed replies in view only while the reader remains at the live edge.
  • Adds bounded delegation, save, and tool-call guardrails for CMP-64.

Problem

The builder chat used ordinary overflow scrolling, so streamed responses did not reliably follow the reader's intent. Separately, a model structured-output miss could cause the parent to delegate again, guess invalid resource contracts, continue editing after a successful save, and eventually exhaust the session token budget.

Solution

Adopt the shared message-scroller behavior with stable turn anchors, saved-thread positioning, and a jump-to-latest control. Move clarification into the builder specialist's durable Eve question flow, enforce one delegation per creation turn, canonicalize integration inputs, lock the draft after save, and cap tool calls, save attempts, and session tokens.

@vercel

vercel Bot commented Aug 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
crm-agent Ready Ready Preview Aug 7, 2026 11:43pm
crm-api Ready Ready Preview Aug 7, 2026 11:43pm
crm-app Ready Ready Preview Aug 7, 2026 11:43pm

Request Review

@ripgrim
ripgrim marked this pull request as ready for review August 7, 2026 20:42
@github-actions github-actions Bot changed the title CMP-63 feat: improve agent chat scrolling and builder resilience fix: bound agent builder retries and improve chat scrolling Aug 7, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 14 files

Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic

Comment thread apps/agent/agent/hooks/builder-delegation.ts
Comment thread apps/agent/agent/subagents/agent_builder/lib/execution-state.ts Outdated
Comment thread apps/agent/agent/subagents/agent_builder/instructions.md
Comment thread apps/agent/agent/subagents/agent_builder/lib/execution-state.ts
Comment thread apps/agent/agent/subagents/agent_builder/agent.ts
Comment thread apps/agent/agent/subagents/agent_builder/lib/draft-input.ts Outdated
@github-actions github-actions Bot changed the title fix: bound agent builder retries and improve chat scrolling feat(agent): bound agent builder retries and improve chat scrolling Aug 7, 2026
@ripgrim
ripgrim merged commit 7780f81 into main Aug 7, 2026
8 checks passed
@ripgrim
ripgrim deleted the rg/cmp-63-message-scroller branch August 7, 2026 23:53
This was referenced Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant