Skip to content

fix(cua-driver-rs/windows): move AttachThreadInput import to correct module (build hotfix)#1617

Merged
f-trycua merged 1 commit into
mainfrom
hotfix/cua-driver-rs-windows-attachthreadinput-import
May 21, 2026
Merged

fix(cua-driver-rs/windows): move AttachThreadInput import to correct module (build hotfix)#1617
f-trycua merged 1 commit into
mainfrom
hotfix/cua-driver-rs-windows-attachthreadinput-import

Conversation

@f-trycua
Copy link
Copy Markdown
Collaborator

@f-trycua f-trycua commented May 21, 2026

Hotfix — #1613's import for AttachThreadInput pointed at KeyboardAndMouse, but windows-rs exposes it from System::Threading. Main build is broken without this. Verified on the VM via scp during #1613 verification (the binary works), but the committed source needs this patch to compile. 1-line move.

Summary by CodeRabbit

  • Chores
    • Updated internal module references for Windows keyboard input handling to ensure proper code organization.

Review Change Stack

…module (build hotfix)

#1613 imported AttachThreadInput from KeyboardAndMouse — windows-rs
actually exposes it from System::Threading. Squash-merge fails to compile:
  error[E0432]: unresolved import
   windows::Win32::UI::Input::KeyboardAndMouse::AttachThreadInput

The corrected source was tested on the VM via scp during #1613
verification, but the committed version on main is broken. This patch
restores the build.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview May 21, 2026 4:12am

Request Review

@f-trycua f-trycua merged commit f5d386e into main May 21, 2026
1 of 2 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b5208fd5-46a7-4918-ae22-f4823130f401

📥 Commits

Reviewing files that changed from the base of the PR and between 680b24e and a36d6b4.

📒 Files selected for processing (1)
  • libs/cua-driver-rs/crates/platform-windows/src/input/keyboard.rs

📝 Walkthrough

Walkthrough

This PR corrects Win32 import paths in the keyboard input module. AttachThreadInput and GetCurrentThreadId are moved to import from windows::Win32::System::Threading, while GetFocus remains imported from windows::Win32::UI::Input::KeyboardAndMouse. No runtime behavior changes.

Changes

Win32 Import Paths

Layer / File(s) Summary
Keyboard input Win32 imports
libs/cua-driver-rs/crates/platform-windows/src/input/keyboard.rs
AttachThreadInput and GetCurrentThreadId import sources are moved to the Threading module, organizing Win32 imports by their correct module categories without altering function usage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through import paths,
Organizing threads with threading baths,
Keyboard focus finds its way,
Clean and sorted, hip hooray! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/cua-driver-rs-windows-attachthreadinput-import

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant