Refactor Docker publish workflow to correctly build and publish multi-arch images #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the reusable Docker publish workflow to generate proper multi-architecture images. Each platform build now pushes by digest and uploads its digest as an artifact, and a final job assembles the multi-arch manifest from those digests.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Updated the manifest creation and inspection steps to loop over metadata-action's `.tags[]` directly and use the full tag references as-is. The previous version attempted to prefix tags with the image name, which produced invalid references (e.g. image:image:tag). Using the full tags emitted by metadata-action ensures correct manifest creation for PR tags, SHA tags, semver tags, and latest.
…hing unwanted tags Split the final metadata-action step into PR, main, and semver-specific blocks so each event only generates the appropriate tags. This prevents PR runs from pushing `latest` or semver tags, ensuring the publish job creates multi-arch manifests only for the tags intended for that event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the reusable Docker publish workflow so that multi-architecture images are generated correctly. Previously, each matrix job pushed directly to the same tag, causing the last completed build to overwrite the manifest and resulting in tags containing only one architecture.
This refactor introduces the recommended Buildx pattern:
docker buildx imagetools create.The workflow continues to support PR builds, main branch builds, and semantic version tags, but now publishes them as proper multi-arch images.
Addresses: #488