🐛 Fixed Analytics Overview dates to use site timezone instead of UTC #25942
+71
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/ghost/issue/NY-381/
Summary
published_atdates in UTC instead of site timezonetimezoneparameter toformatDisplayDateutility functionProblem
The Analytics > Overview tab was showing post dates in UTC, causing confusion when dates appeared as "tomorrow" for users in timezones behind UTC. This was inconsistent with the Ember admin's posts list which correctly displays dates in the site's configured timezone.
Solution
formatDisplayDateinapps/shade/src/lib/utils.tsto accept an optional timezone parametermoment-timezoneto convert ISO dates to the specified timezonelatest-post.tsxandtop-posts.tsxto read the site timezone from settings and pass it to the formatterThis matches the pattern used in the Ember admin's
gh-format-post-timehelper.